Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] hover text is slightly misaligned on starred repos page of GitHub #12538

Closed
LaurenWags opened this issue Nov 5, 2020 · 1 comment
Closed

Comments

@LaurenWags
Copy link
Member

Description

When you hover over the Tip button/text on the starred repos page of a user's GitHub profile, the hover text alignment is slightly off.

Steps to Reproduce

  1. Have Rewards enabled, be logged in to GitHub
  2. Navigate to a user's starred repos page (ex. https://github.com/emerick?tab=stars)
  3. Look for Tip button (note, if you don't see any text saying "Tip", you've encountered [Desktop] race condition with Greaselion and localizations #12264 and need to restart your browser)
  4. Hover over Tip button/text

Actual result:

the ^ part of the hover text is pointing to empty space
GH Tip hovertext

Expected result:

aligned better like on issues/PR page:
GH issue and PR example

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.17.62 Chromium: 86.0.4240.185 (Official Build) dev (x86_64)
Revision 37e6f852ed18086458552039ad26421aa9fc7acc-refs/branch-heads/4240@{#1377}
OS macOS Version 10.14.6 (Build 18G6032)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes 1.16.x
  • Can you reproduce this issue with the beta channel? yes 1.17.x
  • Can you reproduce this issue with the nightly channel? yes 1.18.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @NejcZdovc @emerick

@Miyayes
Copy link
Collaborator

Miyayes commented Feb 15, 2023

Max will be removing these tooltips across the board for inline tip buttons.

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants