Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF gets downloaded instead of opening #1264

Open
bsclifton opened this issue Sep 24, 2018 · 13 comments
Open

PDF gets downloaded instead of opening #1264

bsclifton opened this issue Sep 24, 2018 · 13 comments
Labels
Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix feature/download feature/pdf OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@bsclifton
Copy link
Member

bsclifton commented Sep 24, 2018

Carried over from brave/browser-laptop#10954

Description

PDF gets downloaded instead of opening

Steps to reproduce

  1. Visit this link http://www.fina.org/content/swimming-world-ranking
  2. Generate report, doesnt display
  3. Enable all cookies, pdf downloads
  4. Open same link in Chrome, loads the pdf and doesn't download

Issue above (from browser-laptop) has other good examples too

@bsclifton bsclifton added this to the 2.x Backlog milestone Sep 24, 2018
@bbondy bbondy modified the milestones: 2.x Backlog, 1.x Backlog Sep 30, 2018
@craigs100
Copy link

craigs100 commented Feb 4, 2019

Using Brave Version 0.59.34 Chromium: 72.0.3626.81 (Official Build) (64-bit) on Linux Mint 18.3 Cinnamon:
When downloading a PDF from FreeAgent.com I get the attached screen instead of just a download happening. If I then click the download button shown at the top of the screenshot then the PDF downloads successfully.
The error is "PDF.js v2.0.673 (build: 31012570)
Message: Unexpected server response (401) while retrieving PDF "https://someaccount..freeagent.com/invoices/12345678.pdf".
screenshot from 2019-02-04 09-36-46

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@bsclifton
Copy link
Member Author

bsclifton commented Apr 25, 2019

This appears to be fixed!

@bsclifton
Copy link
Member Author

re-opened as @simonhong was able to reproduce on 0.63.48

@bsclifton bsclifton added feature/shields/cookies Cookie controls implemented as part of Shields. and removed extension/PDFJS labels May 24, 2019
@bsclifton
Copy link
Member Author

Not a problem with PDF.js; still occurs with PDFium. Root cause appears to be 3rd party cookies

@bsclifton bsclifton added webcompat/shields Shields is breaking a website. and removed feature/shields/cookies Cookie controls implemented as part of Shields. labels May 24, 2019
@nxbxdy
Copy link

nxbxdy commented May 31, 2019

I'm having this issue when opening local PDF files on 0.64.77, but only if brave wasn't launched before. Basically only happens if opening the PDF launches brave, it will not apply the extension/component correctly, and ask for a download, even with the "download pdfs instead of opening them" setting disabled.

@flotzone
Copy link

flotzone commented Jul 4, 2019

Having the same issue as @nxbxdy but on Brave Version 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit). Also, I have 2 monitors if that helps somehow.

@jsquyres
Copy link

I am having the same issue:

  1. Here's a public PDF URL where this occurs: https://www.open-mpi.org/papers/euro-pvmmpi-2004-overview/euro-pvmmpi-2004-overview.pdf
    • If you want to see the HTML that links to this PDF, here's the enclosing page -- it's the first "[pdf]" link in the top of the main content: https://www.open-mpi.org/papers/
  2. I am using Brave on MacOS version 0.68.132 Chromium 76.0.3809.132

Screen Shot 2019-09-16 at 10 54 05 AM

@CarlaFernandez
Copy link

I am having the same issue on Ubuntu 18.04:
Brave Version 0.68.132 Chromium: 76.0.3809.132 (Official Build) (64 bits)

@rebron
Copy link
Collaborator

rebron commented Sep 17, 2019

@jsquyres You have this toggled off right? brave://settings/content/pdfDocuments

I can't reproduce what you're seeing on Version 0.68.138 Chromium: 77.0.3865.75 (Official Build) (64-bit) macOS, our current release version. I'm able to see https://www.open-mpi.org/papers/euro-pvmmpi-2004-overview/euro-pvmmpi-2004-overview.pdf and https://www.open-mpi.org/papers/ several of the pdfs in here all in the browser.

@jsquyres
Copy link

@rebron Kudos to you, sir!

No, I did not have that toggled off. Once I toggled it off, I can view PDFs in Brave, birds are signing, unicorns are frolicking, ...etc. 🎉

Thank you for all the hard work on Brave!

@NumDeP
Copy link

NumDeP commented May 6, 2020

Hi @rebron I believe this issue is still persistent. I have Download PDF files instead of automatically opening them in Brave toggle off. in Version 1.8.86 Chromium: 81.0.4044.129 (Official Build) (64-bit) (openSuse)

Try opening this persons resume - https://romainpellerin.eu/ The link is just above 'I'M ONLINE'

Strange thing is, within the hour I also opened another persons CV and that opened in Brave.

Another user issued a similar bug recently as well #9571

@rebron
Copy link
Collaborator

rebron commented May 7, 2020

@NumDeP That particular issue seems to be a github issue and not the usual case for other .pdfs. I was able to reproduce what you saw in Chrome and Firefox as well.

@ryanbr
Copy link

ryanbr commented May 4, 2021

Affects Chrome also. Believe it's related https://bugs.chromium.org/p/chromium/issues/detail?id=333

  • Compared Chrome and Brave. Both will natively show pdf's with it's pdf view.
  • Changing brave://settings/content/pdfDocuments?search=pdf in both Chrome/Brave, will just download the pdf (but not automatically open).

Maybe we close this until it's fixed upstream in Chrome, thoughts? @bsclifton

@bsclifton bsclifton added Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix labels Nov 22, 2021
@rebron rebron added priority/P5 Not scheduled. Don't anticipate work on this any time soon. feature/pdf and removed webcompat/shields Shields is breaking a website. labels May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix feature/download feature/pdf OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
Status: P5 Backlog / waiting upstream
Development

No branches or pull requests

10 participants