adding favicons for custom chrome:// pages under Task Manager

[kjozwiak]

Description

When viewing custom chrome:// pages under the Task Manager, you'll notice that the favicons are blank. Shouldn't be hard to add favicons for these custom pages. Example of some pages affected:

• chrome://newtab
• chrome://rewards
• chrome://adblock
• chrome://version
• chrome://welcome

Steps to Reproduce

1. launch b-c and open chrome://newtab, chrome://rewards, chrome://version
2. open the Task Manager and you'll notice the above processes are missing favicons

Actual result:

Expected result:

Custom chrome:// pages should have favicons associated with them.

Reproduces how often:

100% reproducible using the above STR.

Brave version (chrome://version info)

Brave	0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Mac OS X (10.13.6 x64)

Reproducible on current release:

Yes, currently reproducible under the current release which is 0.55.6 Chromium: 70.0.3538.16. Also reproducible with the latest master:

Brave	0.55.2 Chromium: 70.0.3538.22 (Developer Build) (64-bit)
Revision	ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS	Mac OS X (10.13.6 x64)

[LaurenWags]

Looks like chrome://welcome now has a favicon. Perhaps due to #584 ? Other pages still need favicons though.

Brave	0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision	28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS	Mac OS X

[GeetaSarvadnya]

Favicon for welcome page is missing again in 0.59.12. Looks like regression issue. Logged #2747

[rossmoody]

I'd like to help on this one but it feels a little like a moving target. Might be helpful to break the favicons needed out into their own issues.

[rwhitman2017]

I'll go ahead and take a shot at this issue!

[bsclifton]

@rwhitman2017 check out our CONTRIBUTING.md for help getting started - let us know if there's anything we can help with

[bsclifton]

pulling up task manager now - seems this has been fixed. There are some default icons showing there (like a globe):

Gonna close this out as it's fixed. @rwhitman2017 feel free to find another issue and reach out 😄