Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open link in browser via custom tabs causes menu to show on top and bottom #12784

Closed
srirambv opened this issue Nov 19, 2020 · 1 comment · Fixed by brave/brave-core#7201
Closed

Comments

@srirambv
Copy link
Contributor

Description

Open link in browser via custom tabs causes menu to show on top and bottom

Steps to reproduce

  1. Open a link in custom tab
  2. Open menu and click open link in browser
  3. Switches to browser, has both top and bottom menu

Actual result

https://bravesoftware.slack.com/archives/C0816QH3R/p1605787228433900
customtabs

Expected result

Should not cause menu to show up in both places

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.17.71

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

@btlechowski
Copy link

btlechowski commented Nov 27, 2020

Verification passed on Brave v1.17.74 on Samsung Galaxy Tab S5e (Android 9.0).

  • Verified that the issue does not reproduce on Tablet.

Verification passed on OnePlus 6T with Android 10 running 1.17.74 x64 build

  • Verified steps from issue description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants