Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After fixing an issue: Translation is missing at the Bookmark Context Menu #12904

Closed
bastele7 opened this issue Nov 26, 2020 · 3 comments · Fixed by brave/brave-core#7345
Closed

After fixing an issue: Translation is missing at the Bookmark Context Menu #12904

bastele7 opened this issue Nov 26, 2020 · 3 comments · Fixed by brave/brave-core#7345
Assignees
@mkarolin
Labels
l10n OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.18.x - Release

Comments

@bastele7
Copy link

bastele7 commented Nov 26, 2020 •
edited
Loading

Since the current builds of Brave the translation is missing in the context menu of the bookmarks (was translated at version 1.16.76). Issue was #12844

Current builds
Unbenannt

Previous builds
Unbenannt2
@Furax-31
Copy link

Same problem in french.

@bastele7 bastele7 changed the title Bookmark Context Menu: Translation is missing After fixing an issue: Translation is missing at the Bookmark Context Menu Dec 1, 2020
@bastele7 bastele7 mentioned this issue Dec 1, 2020
Closed
@mkarolin mkarolin self-assigned this Dec 4, 2020
@mkarolin mkarolin mentioned this issue Dec 4, 2020
Merged
23 tasks
This was referenced Dec 7, 2020
Merged
Merged
@kjozwiak kjozwiak added this to the 1.18.x - Release milestone Dec 8, 2020
@btlechowski
Copy link

QA/Blocked till we get a new build (> 1.18.69)

@btlechowski
Copy link

btlechowski commented Dec 9, 2020 •
edited
Loading

Verification passed on

Brave 1.18.70 Chromium: 87.0.4280.101 (Official Build) (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Verified test plan from the description

image
image
image
image

Rest of the testing done under #13040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
l10n OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.18.x - Release
Development

Successfully merging a pull request may close this issue.

Fix missing Chromium l10n strings. brave/brave-core
6 participants
@kjozwiak @LaurenWags @btlechowski @mkarolin @Furax-31 @bastele7