Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match redirect chain URLs against Brave Ad conversion URL patterns #13033

Closed
tmancey opened this issue Dec 3, 2020 · 1 comment · Fixed by brave/brave-core#7330
Closed

Match redirect chain URLs against Brave Ad conversion URL patterns #13033

tmancey opened this issue Dec 3, 2020 · 1 comment · Fixed by brave/brave-core#7330
Assignees
@tmancey
Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.19.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Dec 3, 2020

No description provided.

@tmancey tmancey added enhancement priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/ads OS/Desktop labels Dec 3, 2020
@tmancey tmancey self-assigned this Dec 3, 2020
@tmancey tmancey mentioned this issue Dec 3, 2020
Merged
23 tasks
@tmancey tmancey added this to the 1.20.x - Nightly milestone Dec 4, 2020
This was referenced Dec 15, 2020
Merged
Merged
@btlechowski
Copy link

btlechowski commented Jan 8, 2021 •
edited by GeetaSarvadnya
Loading

Verification passed on

Brave 1.20.60 Chromium: 88.0.4315.7 (Official Build) nightly (64-bit)
Revision 9b020863b2987261f6dcd018c6b388041c035f98-refs/branch-heads/4315@{#15}
OS Ubuntu 18.04 LTS

Important: Permanent redirects are not supported. Only 307 redirects are supported.

Verified test plan from https://github.com/brave/internal/issues/745
Convert 307 redirect - no wildcard
Verified conversion was triggered

[1146:1146:0108/114516.272806:VERBOSE1:ad_notification_serving.cc(98)] Ad notification delivered:
  uuid: 7061476a-4d90-45bf-9e41-8220549fb297
  creativeInstanceId: 30ecd70f-f56d-4745-a457-4035fcab54b6
  creativeSetId: 0a697a3b-233a-44bc-a337-e2441fb277a7
  campaignId: d4d0474c-277a-4714-b25d-7b484cdb580a
  category: untargeted
  title: Ad conversion with 307 redirect - no wildcard
  body: Ad conversion with 307 redirect - no wildcard
  targetUrl: http://test.greenbytes.de/tech/tc/httpredirects/t307loc.asis

[1146:1146:0108/114520.030994:VERBOSE1:conversions.cc(230)] Conversion for creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7 and ad_notification
[1146:1146:0108/114520.032084:VERBOSE1:conversions.cc(396)] Convert creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7 on sobota, 9 stycznia 2021 12:32:24
[1146:1146:0108/114520.050492:VERBOSE6:conversions.cc(290)] Successfully logged conversion event

Convert 307 redirect - wildcard
Verified conversion was triggered

[31923:31923:0108/113703.850608:VERBOSE1:ad_notification_serving.cc(98)] Ad notification delivered:
  uuid: 56c5555f-ec70-490f-868f-9f9cb0db0413
  creativeInstanceId: 30ecd70f-f56d-4745-a457-4035fcab54b6
  creativeSetId: 0a697a3b-233a-44bc-a337-e2441fb277a7
  campaignId: d4d0474c-277a-4714-b25d-7b484cdb580a
  category: untargeted
  title: Ad conversion with 307 redirect - wildcard
  body: Ad conversion with 307 redirect - wildcard
  targetUrl: http://test.greenbytes.de/tech/tc/httpredirects/t307loc.asis?id=11111

[31923:31923:0108/113709.577770:VERBOSE1:conversions.cc(230)] Conversion for creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7 and ad_notification
[31923:31923:0108/113709.581624:VERBOSE1:conversions.cc(396)] Convert creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7 in 1 godzina, 13 minut i 38 sekund at 12:50
[31923:31923:0108/113709.593823:VERBOSE6:conversions.cc(290)] Successfully logged conversion event

Verification PASSED on macOS 11.1 x64 using the following build:

Brave | 1.19.81 Chromium: 87.0.4280.141 (Official Build) dev (x86_64)
--- | ---
Revision | 9f05d1d9ee7483a73e9fe91ddcb8274ebcec9d7f-refs/branch-heads/4280@{#2007}
OS | macOS Version 11.1 (Build 20C69)

Convert 307 redirect - no wildcard

Verified that a conversion was triggered using the STR/Cases outlined via https://github.com/brave/internal/issues/745 as per the following:

[61558:775:0113/013140.810943:VERBOSE1:ad_notification_serving.cc(98)] Ad notification delivered:
  uuid: 42c9332a-a21f-4b89-b16b-a481c2dd2bac
  creativeInstanceId: 30ecd70f-f56d-4745-a457-4035fcab54b6
  creativeSetId: 0a697a3b-233a-44bc-a337-e2441fb277a7
  campaignId: d4d0474c-277a-4714-b25d-7b484cdb580a
  category: untargeted
  title: Ad conversion with 307 redirect - no wildcard
  body: Ad conversion with 307 redirect - no wildcard
  targetUrl: http://test.greenbytes.de/tech/tc/httpredirects/t307loc.asis
  
[61558:775:0113/013145.141177:VERBOSE1:conversions.cc(230)] Conversion for creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7 and ad_notification
[61558:775:0113/013145.141489:VERBOSE1:conversions.cc(396)] Convert creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7 in 9 hours, 16 minutes, 16 seconds at 10:48 AM
[61558:775:0113/013145.142792:VERBOSE6:conversions.cc(290)] Successfully logged conversion event

Convert 307 redirect - wildcard

Verified that a conversion was triggered using the STR/Cases outlined via https://github.com/brave/internal/issues/745 as per the following:

[61726:775:0113/014405.644709:VERBOSE1:ad_notification_serving.cc(98)] Ad notification delivered:
  uuid: bca354a6-3d45-42a2-891a-322370968311
  creativeInstanceId: 30ecd70f-f56d-4745-a457-4035fcab54b6
  creativeSetId: 0a697a3b-233a-44bc-a337-e2441fb277a7
  campaignId: d4d0474c-277a-4714-b25d-7b484cdb580a
  category: untargeted
  title: Ad conversion with 307 redirect - wildcard
  body: Ad conversion with 307 redirect - wildcard
  targetUrl: http://test.greenbytes.de/tech/tc/httpredirects/t307loc.asis?id=11111
  
[61726:775:0113/014408.090126:VERBOSE1:conversions.cc(230)] Conversion for creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7 and ad_notification
[61726:775:0113/014408.090282:VERBOSE1:conversions.cc(396)] Convert creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and creative set id 0a697a3b-233a-44bc-
[61726:775:0113/014408.093052:VERBOSE6:conversions.cc(290)] Successfully logged conversion event

Verification passed on

Brave | 1.19.83 Chromium: 88.0.4324.79 (Official Build) (64-bit)
-- | --
Revision | bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS | Windows 10 OS Version 2004 (Build 19041.685)

Verified test plan from https://github.com/brave/internal/issues/745
Convert 307 redirect - no wildcard
Verified conversion was triggered

[25048:24172:0115/111144.874:VERBOSE1:ad_notification_serving.cc(98)] Ad notification delivered:
  uuid: c2bd616d-215f-4f86-a4ee-ccedc03dcad9
  creativeInstanceId: 30ecd70f-f56d-4745-a457-4035fcab54b6
  creativeSetId: 0a697a3b-233a-44bc-a337-e2441fb277a7
  campaignId: d4d0474c-277a-4714-b25d-7b484cdb580a
  category: untargeted
  title: Ad conversion with 307 redirect - no wildcard
  body: Ad conversion with 307 redirect - no wildcard
  targetUrl: http://test.greenbytes.de/tech/tc/httpredirects/t307loc.asis

[25048:24172:0115/111150.494:VERBOSE1:conversions.cc(230)] Conversion for creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7 and ad_notification
[25048:24172:0115/111150.495:VERBOSE1:conversions.cc(396)] Convert creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7 in 16 hours, 5 minutes, 5 seconds at 3:16 AM
[25048:24172:0115/111150.502:VERBOSE6:conversions.cc(290)] Successfully logged conversion event

Convert 307 redirect - wildcard
Verified conversion was triggered

[22648:7944:0115/112257.080:VERBOSE1:ad_notification_serving.cc(98)] Ad notification delivered:
  uuid: 8d49590d-e3ce-4d56-9f96-defc8ff4255d
  creativeInstanceId: 30ecd70f-f56d-4745-a457-4035fcab54b6
  creativeSetId: 0a697a3b-233a-44bc-a337-e2441fb277a7
  campaignId: d4d0474c-277a-4714-b25d-7b484cdb580a
  category: untargeted
  title: Ad conversion with 307 redirect - wildcard
  body: Ad conversion with 307 redirect - wildcard
  targetUrl: http://test.greenbytes.de/tech/tc/httpredirects/t307loc.asis?id=11111
[22648:7944:0115/112300.906:VERBOSE1:conversions.cc(230)] Conversion for creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7 and ad_notification
[22648:7944:0115/112300.906:VERBOSE1:conversions.cc(396)] Convert creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7 in 4 hours, 32 minutes, 11 seconds at 3:55 PM
[22648:7944:0115/112300.915:VERBOSE6:conversions.cc(290)] Successfully logged conversion event

@kjozwiak kjozwiak mentioned this issue Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Ads
Archived in project
Milestone
1.19.x - Release
Development

Successfully merging a pull request may close this issue.

Match redirect chain URLs against Brave Ad conversion URL patterns brave/brave-core
4 participants
@tmancey @kjozwiak @btlechowski @GeetaSarvadnya