Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom RSS to Brave News #13095

Closed
Alonely0 opened this issue Dec 8, 2020 · 23 comments · Fixed by brave/brave-core#11391 or brave/brave-core#11975
Closed

Add custom RSS to Brave News #13095

Alonely0 opened this issue Dec 8, 2020 · 23 comments · Fixed by brave/brave-core#11391 or brave/brave-core#11975

Comments

@Alonely0
Copy link

Alonely0 commented Dec 8, 2020

Description

I love Brave Today, but I have a problem. Some news sites that I usually read aren't available in brave today sites, so I like to put them via their RSS feed.

Brave version (brave://version info)

brave://version brave://version
Version Brave: 1.20.17 nightly (64 bits) (Build official) Chromium: 87.0.4280.88
Revision 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS Arch Linux
Execution flags /opt/brave.com/brave-nightly/brave --enable-dom-distiller --disable-domain-reliability --no-pings --extension-content-verification=enforce_strict --extensions-install-verification=enforce --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --enable-features=AutoupgradeMixedContent,WebUIDarkMode,DnsOverHttps,LegacyTLSEnforced,PasswordImport,ReducedReferrerGranularity,PrefetchPrivacyChanges --disable-features=AutofillEnableAccountWalletStorage,AutofillServerCommunication,TextFragmentAnchor,NetworkTimeServiceQuerying,PasswordCheck,IdleDetection,SignedExchangeSubresourcePrefetch,SafeBrowsingEnhancedProtection,PrivacySettingsRedesign,AllowPopupsDuringPageUnload,VideoPlaybackQuality,NotificationTriggers,SmsReceiver,TabHoverCards --flag-switches-begin --flag-switches-end
Binary path /opt/brave.com/brave-nightly/brave
Profile path /home/guillem/.config/BraveSoftware/Brave-Browser-Nightly/Default
Installation font Arch User Repository (AUR)
@underling3311
Copy link

That's a good idea, would put as feature request. If I able to add feature request.

@Alonely0
Copy link
Author

Alonely0 commented Dec 9, 2020

@MrWaste When I was going to submit the issue, I couldn't submit it as a feature request, so if anyone of the brave team could add the labels of feature-request and feature/brave-today, it would be very helpful to carry out the objective of this feature suggestion.

@Alonely0 Alonely0 changed the title Suggestion: Add custom RSS to brave today Feature request: Add custom RSS to brave today Dec 9, 2020
@Alonely0
Copy link
Author

Alonely0 commented Dec 9, 2020

I think that title describes better the objective of the issue.

@wagk
Copy link

wagk commented Jan 23, 2021

I would also very much like this feature to be implemented (it would be great if Brave could replace my current RSS reader)

@bsclifton bsclifton added the feature/brave-news formerly brave-today label Jan 26, 2021
@bsclifton
Copy link
Member

cc: @mattmcalister @petemill for priority / triage

@Alonely0
Copy link
Author

I would also very much like this feature to be implemented (it would be great if Brave could replace my current RSS reader)

I currently use the new tab of glance because I like to see the news on the new tab. (I also recommend night tab, does not have RSS but is the most customizable new tab in the world).

@rebron rebron changed the title Feature request: Add custom RSS to brave today Add custom RSS to Brave Today Mar 1, 2021
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 19, 2021
@DarkGhost7
Copy link

Yes, I would love this feature! Really need a custom RSS feed for news.

@MrTob
Copy link

MrTob commented May 16, 2021

this feature would be very helpful. what is the current standing?

@mattmcalister
Copy link

this feature would be very helpful. what is the current standing?

it's live on iOS now. desktop is progressing nicely and Android will be coming, too, but please be patient.

@DarkGhost7
Copy link

this feature would be very helpful. what is the current standing?

it's live on iOS now. desktop is progressing nicely and Android will be coming, too, but please be patient.

Letsss goooo

@bsclifton bsclifton changed the title Add custom RSS to Brave Today Add custom RSS to Brave News Jun 14, 2021
@mlhaufe
Copy link

mlhaufe commented Aug 16, 2021

If I click on an RSS link, what should the expected behavior be? Seeing the raw XML does not seem to be the right thing to do if the above feature is now in place.

@JimB-Dev
Copy link

If I click on an RSS link, what should the expected behavior be? Seeing the raw XML does not seem to be the right thing to do if the above feature is now in place.

As far as I know it is not in place anywhere besides iOS. The above issue was closed only because it was a duplicate of this one. But I don't believe custom RSS is available for desktop or Android yet. Still waiting.

@UjCbFwtBayFM
Copy link

There's a custom RSS reader feature in Chrome Mobile, but it's unavailable in Brave.

@JJohnGreenSr
Copy link

Indeed, I was actually ecstatic when I saw that announcement about RSS feeds on Chrome 94, so I tried to look for it on Brave (my browser is, after all, built on Chromium 94). Apparently it isn't in here, which would be one of the first Chrome features I'd care about that's not downstreamed.

@UjCbFwtBayFM
Copy link

As far as I've seen the feature is in Brave Mobile, but not accessible/usable.
Guess your best bet is to wait until Brave re-brand it as their own feature.

@bsclifton bsclifton added this to the 1.36.x - Nightly milestone Jan 21, 2022
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 24, 2022
@stephendonner
Copy link

stephendonner commented Jan 24, 2022

Verified PASSED using

Brave 1.36.73 Chromium: 98.0.4758.66 (Official Build) nightly (x86_64)
Revision db1b4001d5ce29f141297f260d2b778e000b85a3-refs/branch-heads/4758@{#762}
OS macOS Version 12.2 (Build 21D48)
Case 1: Adding a new feed via customize panel should immediately add to the list
  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. clicked on Customize
  7. pasted the CNN Top Stories RSS feed into the Feed URL textfield (http://rss.cnn.com/rss/cnn_topstories.rss)
  8. clicked Add source
  9. clicked on Top News
  10. deselected CNN
  11. opened a new-tab page
  12. scrolled down

Confirmed I got content from CNN.com - RSS Channel - HP Hero, which is from my custom-RSS source.

example example example
Screen Shot 2022-01-24 at 2 41 17 PM Screen Shot 2022-01-24 at 3 37 58 PM Screen Shot 2022-01-24 at 3 38 02 PM
Case 2: The feed title should be displayed in the customize panel list
  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. clicked on Customize
  7. pasted the CNN Top Stories RSS feed into the Feed URL textfield (http://rss.cnn.com/rss/cnn_topstories.rss)

Confirmed I got CNN.com - RSS Channel - HP Hero listed beneath Your Sources

example example
Screen Shot 2022-01-24 at 3 37 58 PM Screen Shot 2022-01-24 at 3 38 02 PM
Case 3: Adding an incorrect feed url should present an error message
  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. clicked on Customize
  7. pasted the following non-working URL: http://rss.cnn.com/rss/cnn_topstories-obvious-404.rss into Feed URL
  8. clicked on Add source

Confirmed I got an Sorry, we couldn't find a feed at that address. error message.

example example
Screen Shot 2022-01-24 at 3 54 26 PM Screen Shot 2022-01-24 at 3 54 30 PM
Case 4: Content from the new feed should be displayed in the feed list on next refresh

a) feed added case is already covered; see case 1 & 2
b) browser restart

  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. clicked on Customize
  7. clicked on Top News under Sources
  8. clicked to toggle CNN to OFF
  9. clicked <- Back
  10. pasted the CNN Top Stories RSS feed into the Feed URL textfield (http://rss.cnn.com/rss/cnn_topstories.rss)
  11. clicked Add source
  12. confirmed I got the Load new content button
  13. restarted Brave
  14. opened Brave News
  15. confirmed CNN.com - RSS Channel - HP Hero articles appeared in the feed
example example example example
Screen Shot 2022-01-24 at 10 26 34 PM Screen Shot 2022-01-24 at 10 28 05 PM Screen Shot 2022-01-24 at 10 30 11 PM Screen Shot 2022-01-24 at 10 28 36 PM

c) 3 hour interval

  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. clicked on Customize
  7. deselected all other feed sources
  8. pasted the CNN Top Stories RSS feed into the Feed URL textfield (http://rss.cnn.com/rss/cnn_topstories.rss)
  9. waited 3 hours+
  10. (should have a Load new content button)
example example example example
Screen Shot 2022-01-24 at 10 28 05 PM Screen Shot 2022-01-24 at 10 26 34 PM Screen Shot 2022-01-24 at 11 46 09 PM Screen Shot 2022-01-25 at 1 49 30 AM
Case 5: Removing a feed removes it from the feed list and removes its content via customize panel
  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. confirmed I saw an Daily Mail article
  7. clicked on Customize
  8. clicked on Top News
  9. clicked to toggle Daily Mail to OFF
  10. clicked the X to close the dialog
  11. confirmed I saw the Load new content button
  12. clicked on Load new content
  13. scrolled through Brave News

Confirmed I no longer saw Daily Mail articles.

example example example example
Screen Shot 2022-01-24 at 3 56 20 PM Screen Shot 2022-01-24 at 3 57 15 PM Screen Shot 2022-01-24 at 3 56 27 PM Screen Shot 2022-01-24 at 3 56 31 PM
Case 6: Removing a feed removes it from the feed list and removes its content via clicking the publisher name on a content card by that publisher
  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. confirmed I saw an ABC News article
  7. clicked on ABC News at the bottom
  8. clicked on Disable content from ABC News
  9. confirmed I saw the Load new content button
  10. clicked on Load new content
  11. scrolled through Brave News

Confirmed I no longer saw ABC News articles.

example example example
Screen Shot 2022-01-24 at 3 48 19 PM Screen Shot 2022-01-24 at 3 48 27 PM Screen Shot 2022-01-24 at 3 49 06 PM

Verified PASSED using

Brave 1.36.87 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS Windows 11 Version 21H2 (Build 22000.469)
Case 1: Adding a new feed via customize panel should immediately add to the list
  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. clicked on Customize
  7. pasted the CNN Top Stories RSS feed into the Feed URL text field (http://rss.cnn.com/rss/cnn_topstories.rss)
  8. clicked Add source
  9. clicked on Top News under Sources list
  10. toggle off CNN
  11. opened a new-tab page
  12. scrolled down
  13. Verified content returned from CNN.com - RSS Channel - HP Hero, which is from my custom-RSS source.
example example example
Screenshot 2022-02-08 170031 Screenshot 2022-02-08 170129 Screenshot 2022-02-08 170227
Case 2: The feed title should be displayed in the customize panel list
  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. clicked on Customize
  7. pasted the CNN Top Stories RSS feed into the Feed URL text field (http://rss.cnn.com/rss/cnn_topstories.rss)

Verified content returned from CNN.com - RSS Channel - HP Hero listed beneath Your Sources

example example
RSS feed in the feed URL Your sources
Case 3: Adding an incorrect feed url should present an error message
  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. clicked on Customize
  7. pasted the following non-working URL: http://rss.cnn.com/rss/cnn_topstories-obvious-404.rss into Feed URL
  8. clicked on Add source

Verified error message returned Sorry, we couldn't find a feed at that address.

example
Incorrect feed URL message
Case 4: Content from the new feed should be displayed in the feed list on next refresh

a) feed added case is already covered; see case 1 & 2
b) browser restart

  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. clicked on Customize
  7. clicked on Top News under Sources
  8. clicked to toggle CNN to OFF
  9. clicked <- Back
  10. pasted the CNN Top Stories RSS feed into the Feed URL text field (http://rss.cnn.com/rss/cnn_topstories.rss)
  11. clicked Add source
  12. Verified Load new content button loaded
  13. restarted Brave
  14. opened Brave News

Verified CNN.com - RSS Channel - HP Hero articles appeared in the feed

example example example example
Turnoffsetting Add URL Load content news card displayed

c) 3 hour interval

  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. clicked on Customize
  7. deselected all other feed sources
  8. pasted the CNN Top Stories RSS feed into the Feed URL text field (http://rss.cnn.com/rss/cnn_topstories.rss)
  9. waited 3 hours+
  10. (should have a Load new content button)

Verified Load new content button loaded

example example example example example
deselect all sources feed url your sources Load content Content displayed
Case 5: Removing a feed removes it from the feed list and removes its content via customize panel
  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. Verified Daily Mail article available
  7. clicked on Customize
  8. clicked on Top News
  9. clicked to toggle Daily Mail to OFF
  10. clicked the X to close the dialog
  11. Verified Load new content button loaded
  12. clicked on Load new content
  13. scrolled through Brave News

Verified Daily Mail articles are not displayed

example example
Screenshot 2022-02-08 201556 Screenshot 2022-02-08 201435
Case 6: Removing a feed removes it from the feed list and removes its content via clicking the publisher name on a content card by that publisher
  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. verified Forbes article is available
  7. clicked on Forbes at the bottom
  8. clicked on Disable content from 'Forbes
  9. confirmed I saw the Load new content button
  10. clicked on Load new content
  11. scrolled through Brave News

Verified 'Forbes` articles are not available

example example example example
Forbes news card Disable Load content card not available

Verified PASSED using

Brave 1.36.93 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS Linux
Case 1: Adding a new feed via customize panel should immediately add to the list
  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. clicked on Customize
  7. pasted the CNN Top Stories RSS feed into the Feed URL textfield (http://rss.cnn.com/rss/cnn_topstories.rss)
  8. clicked Add source
  9. clicked on Top News
  10. deselected CNN
  11. opened a new-tab page
  12. scrolled down

Confirmed I got content from CNN.com - RSS Channel - HP Hero, which is from my custom-RSS source.

example example example
Screen Shot 2022-02-14 at 10 51 39 AM Screen Shot 2022-02-14 at 10 52 06 AM Screen Shot 2022-02-14 at 10 52 56 AM
Case 2: The feed title should be displayed in the customize panel list
  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. clicked on Customize
  7. pasted the CNN Top Stories RSS feed into the Feed URL textfield (http://rss.cnn.com/rss/cnn_topstories.rss)

Confirmed I got CNN.com - RSS Channel - HP Hero listed beneath Your Sources

example example
Screen Shot 2022-02-14 at 10 56 20 AM Screen Shot 2022-02-14 at 10 56 23 AM
Case 3: Adding an incorrect feed URL should present an error message
  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. clicked on Customize
  7. pasted the following non-working URL: http://rss.cnn.com/rss/cnn_topstories-obvious-404.rss into Feed URL
  8. clicked on Add source

Confirmed I got an Sorry, we couldn't find a feed at that address. error message.

example example
Screen Shot 2022-02-14 at 10 58 09 AM
Case 4: Content from the new feed should be displayed in the feed list on next refresh

a) feed added case is already covered; see case 1 & 2
b) browser restart

  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. clicked on Customize
  7. clicked on Top News under Sources
  8. clicked to toggle CNN to OFF
  9. clicked <- Back
  10. pasted the CNN Top Stories RSS feed into the Feed URL textfield (http://rss.cnn.com/rss/cnn_topstories.rss)
  11. clicked Add source
  12. confirmed I got the Load new content button
  13. restarted Brave
  14. opened Brave News
  15. confirmed CNN.com - RSS Channel - HP Hero articles appeared in the feed
example example example
Screen Shot 2022-02-14 at 11 02 03 AM Screen Shot 2022-02-14 at 11 02 33 AM Screen Shot 2022-02-14 at 11 02 53 AM

c) 3 hour interval

  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. clicked on Customize
  7. deselected all other feed sources
  8. pasted the CNN Top Stories RSS feed into the Feed URL textfield (http://rss.cnn.com/rss/cnn_topstories.rss)
  9. waited 3 hours+
  10. (should have a Load new content button)
example example example example
Case 5: Removing a feed removes it from the feed list and removes its content via customize panel
  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. confirmed I saw an Daily Mail article
  7. clicked on Customize
  8. clicked on Top News
  9. clicked to toggle Daily Mail to OFF
  10. clicked the X to close the dialog
  11. confirmed I saw the Load new content button
  12. clicked on Load new content
  13. scrolled through Brave News

Confirmed I no longer saw Daily Mail articles.

example example
Screen Shot 2022-02-14 at 11 04 51 AM Screen Shot 2022-02-14 at 11 05 15 AM
Case 6: Removing a feed removes it from the feed list and removes its content via clicking the publisher name on a content card by that publisher
  1. new profile
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down
  5. clicked on Show Brave News
  6. confirmed I saw an Forbes article
  7. clicked on Forbes at the bottom
  8. clicked on Disable content from Forbes
  9. confirmed I saw the Load new content button
  10. clicked on Load new content
  11. scrolled through Brave News

Confirmed I no longer saw Forbes articles.

example example example example
Screen Shot 2022-02-14 at 11 08 02 AM Screen Shot 2022-02-14 at 11 08 04 AM Screen Shot 2022-02-14 at 11 08 10 AM Screen Shot 2022-02-14 at 11 08 48 AM

@petemill petemill reopened this Jan 24, 2022
@petemill
Copy link
Member

This was temporarily reverted but will be reintroduced ASAP

@sergioad
Copy link

Could this be added to Android and iOS too I wish I could add all the tech and videogame feeds I love to read both in English and Spanish

@stephendonner
Copy link

Could this be added to Android and iOS too I wish I could add all the tech and videogame feeds I love to read both in English and Spanish

This has been in iOS since early last year: https://www.thegoandroid.com/brave-today-feature-enables-the-user-to-add-rss-feeds/113312/. Android is still pending (keep watching nightly builds; I don't have an issue # for custom-RSS support handy, sorry).

@petemill @alexsafe do we have a separate issue for custom-RSS feeds on Android?

@sergioad
Copy link

@petemill @alexsafe sorry for tagging you, but if you could add this feature I would thank you a lot, I would love to read my favorite Mexican blogs like Xataka Mexico or Xbox wire en Espanol on my favorite browser

@stephendonner
Copy link

@petemill @alexsafe sorry for tagging you, but if you could add this feature I would thank you a lot, I would love to read my favorite Mexican blogs like Xataka Mexico or Xbox wire en Espanol on my favorite browser

@sergioad follow #21272 for updates on custom RSS for Android 👍

@aman-m1
Copy link

aman-m1 commented Feb 25, 2022

I would like a toggle to toggle off all the contents from Brave News except my added feeds. Currenty it requires quite some time to toggle each one off. Also a button to show my added feeds first as I see default sources being prioratised after almost every refresh.

Also all my added urls are displayed without any thumbnail-

Screenshot 2022-02-26 010259
I added them from here-
https://indianexpress.com/syndication/
https://www.ndtv.com/rss
https://www.indiatoday.in/rss
https://www.thehindu.com/rssfeeds/

And a way to sync feed urls across devices. Also I don't have a way to edit them if I wanted to.

@aman-m1
Copy link

aman-m1 commented Feb 25, 2022

And +1 for Android. As soon as you can. I prefer a privacy preserved way to view news and mobile is much more handy than a laptop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment