Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing incognito property to brave-extension manifest #1323

Closed
bsclifton opened this issue Sep 27, 2018 · 0 comments
Closed

Add missing incognito property to brave-extension manifest #1323

bsclifton opened this issue Sep 27, 2018 · 0 comments

Comments

@bsclifton
Copy link
Member

Description

The extension manifest for brave-extension should have it's incognito property matching what is set in the browser-laptop (Muon) version

Per the docs, Chromium would spin up a secure process for the instances using this extension in private mode, which is what we want. Those private instances do not have access to non-private profiles

This change should help in solving #1198

Additional details

You can see the browser-laptop version of the manifest here:
https://github.com/brave/browser-laptop/blob/41e46f9ce7e0d4f7a558646f377e40d29d0e101d/app/extensions.js#L36-L216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant