Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fractional numbers when recording media viewing time #1349

Open
jasonrsadler opened this issue Sep 28, 2018 · 1 comment
Open

Use fractional numbers when recording media viewing time #1349

jasonrsadler opened this issue Sep 28, 2018 · 1 comment
Assignees
Labels
feature/rewards priority/P4 Planned work. We expect to get to it "soon".

Comments

@jasonrsadler
Copy link

Description

Current viewing time for youtube videos is recording by saving the viewing time as int when the time reporting interval comes in. This can result in the gain or loss of seconds to the actual viewing time.

Steps to Reproduce

  1. Open youtube videos
  2. Compare viewing times with recorded viewing times

Actual result:

Viewing times recorded can on occasion be off by multiple seconds from what the actual viewing time is

Expected result:

Viewing time recorded should closely match the actual viewing time

Reproduces how often:

Brave version (chrome://version info)

Brave 0.57.1 Chromium: 70.0.3538.35 (Developer Build) (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X

Reproducible on current release:

Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc @NejcZdovc

@jasonrsadler jasonrsadler added this to the 1.x Backlog milestone Sep 28, 2018
@jasonrsadler jasonrsadler self-assigned this Sep 28, 2018
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Oct 5, 2018
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@Miyayes
Copy link
Collaborator

Miyayes commented Feb 3, 2023

@zenparsing Is this possibly resolved by your recent work on A-C measurement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

4 participants