Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--help option broken on Linux builds #13614

Open
acli opened this issue Jan 15, 2021 · 4 comments
Open

--help option broken on Linux builds #13614

acli opened this issue Jan 15, 2021 · 4 comments
Labels
OS/Desktop OS/Linux priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@acli
Copy link

acli commented Jan 15, 2021

Description

The --help command-line option is broken on the current Ubuntu build

Steps to Reproduce

  1. Install the build using the official instructions
  2. On the command line, run brave-browser --help

Actual result:

The brave-browser script returns

 No manual entry for brave

Expected result:

The manual entry for brave-browser(1) should show. The manual page exists

Reproduces how often:

Always

Brave version (brave://version info)

Version 1.18.78 Chromium: 87.0.4280.141 (Official Build) (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Will verify later
  • Can you reproduce this issue with the nightly channel? Will verify later

Other Additional Information:

n/a

Miscellaneous Information:

n/a

@fmarier fmarier changed the title --help option broken on Ubuntu build --help option broken on Linux builds Jan 16, 2021
@fmarier
Copy link
Member

fmarier commented Jan 16, 2021

This switch is handled in Chrome using this code and it essentially just calls "man".

I found that all of these work:

man brave-browser-stable
man brave-browser-beta
man brave-browser

but not:

man brave

After instrumenting the code, I confirmed that binary.BaseName().value() maps to brave and so that's why the manpage can't be found.

@fmarier
Copy link
Member

fmarier commented Jan 16, 2021

I found the root cause to be this customization we made in #4142 to the launcher/wrapper in order to work-around non-fatal crashes.

@fmarier
Copy link
Member

fmarier commented Jan 16, 2021

@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Apr 19, 2021
@DeLuca-Agustin
Copy link

I am having the same problem but I don't understand how to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Desktop OS/Linux priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
Status: P5 Backlog / waiting upstream
Development

No branches or pull requests

4 participants