Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set P3A enabled for existing users #13871

Closed
deeppandya opened this issue Feb 1, 2021 · 1 comment · Fixed by brave/brave-core#7765
Closed

Set P3A enabled for existing users #13871

deeppandya opened this issue Feb 1, 2021 · 1 comment · Fixed by brave/brave-core#7765
Assignees
@deeppandya
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.20.x - Release

Comments

@deeppandya
Copy link

Description

This is the follow up issue of #12723 to make p3a enabled for existing users.

Test plan

P3A should be enabled for existing user when the modal for P3A is shown.
@deeppandya deeppandya added QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality labels Feb 1, 2021
@deeppandya deeppandya self-assigned this Feb 1, 2021
This was referenced Feb 1, 2021
Closed
Merged
@brave-builds brave-builds mentioned this issue Feb 2, 2021
Merged
4 tasks
@kjozwiak kjozwiak added this to the 1.20.x - Beta milestone Feb 3, 2021
@srirambv
Copy link
Contributor

srirambv commented Feb 8, 2021

Verification passed on OnePlus 6T with Android 10 running 1.20.100 x64 build

  • Verified P3A opt-in onboarding is enabled by default on upgrade.
  • Verified clicking on continue enables settings to send P3A metrics
  • Verified without clicking on continue in P3A onboarding, backgrounding app and relaunching set P3A metrics to be sent

Verification passed on Samsung Tab A with Android 10 running 1.20.100 x64 build

  • Verified P3A opt-in onboarding is enabled by default on upgrade.
  • Verified clicking on continue enables settings to send P3A metrics
  • Verified without clicking on continue in P3A onboarding, backgrounding app and relaunching set P3A metrics to be sent

@kjozwiak kjozwiak mentioned this issue Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.20.x - Release
Development

Successfully merging a pull request may close this issue.

Set P3A enabled for existing users brave/brave-core
3 participants
@kjozwiak @deeppandya @srirambv