Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google login for extensions is blocked on brave-core #14041

Closed
jumde opened this issue Feb 8, 2021 · 15 comments
Closed

Google login for extensions is blocked on brave-core #14041

jumde opened this issue Feb 8, 2021 · 15 comments
Labels
closed/duplicate Issue has already been reported OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. regression

Comments

@jumde
Copy link
Contributor

jumde commented Feb 8, 2021

Description

Google login for extensions is blocked for extensions.

Steps to Reproduce

  1. Enable Google Login for extensions in brave://settings/extensions
  2. Download Google Keep extension and try to login to Google.
  3. Login on browser works, but extension does not log-in.

Actual result:

Google login doesn't work for extensions

Expected result:

Extension should login as well.

Reproduces how often:

Easily

Brave version (brave://version info)

1.21.36 Chromium: 88.0.4324.96 (Official Build) nightly (x86_64)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@agrawalsourav98
Copy link

I am also facing the same issue, it keeps taking me to the google login screen although I am already logged in

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 9, 2021
@jocon-grmtx
Copy link

Same here. I make extensive use of Google keep, to a point where I have to switch to Chrome (I would prefer to stay on Brave !)

@jumde
Copy link
Contributor Author

jumde commented Feb 10, 2021

@agrawalsourav98 @jocon-grmtx - Thanks for the feedback. We are currently investigating this issue, will post updates as we have them. Could you please confirm if you're seeing this message in brave://signin-internals: Missing authorization code due to OAuth outage in Dice - Thanks!

@agrawalsourav98
Copy link

Yes, I am attaching the screenshot of the page
brave-debug

@jumde
Copy link
Contributor Author

jumde commented Feb 23, 2021

Thanks for the update @agrawalsourav98

@d1zmal
Copy link

d1zmal commented Feb 25, 2021

Was not working for me, however I've been able to get it working by:

  • ensuring Keep extension is uninstalled
  • enabling Allow Google login for extensions
  • relaunching Brave
  • reinstalling Keep extension
  • clicking on the Keep "sign-in" button
  • signing into Google via the newly-opened tab

Evidence of desired behaviour:

2021-02-25 10_53_55-Window

Brave build:

2021-02-25 10_57_29-Window

@agrawalsourav98
Copy link

Was not working for me, however I've been able to get it working by:

  • ensuring Keep extension is uninstalled
  • enabling Allow Google login for extensions
  • relaunching Brave
  • reinstalling Keep extension
  • clicking on the Keep "sign-in" button
  • signing into Google via the newly-opened tab

Evidence of desired behaviour:

2021-02-25 10_53_55-Window

Brave build:

2021-02-25 10_57_29-Window

It didn't work for me

@jumde
Copy link
Contributor Author

jumde commented Feb 28, 2021

Hi all, just an update here - usage of Google oauth credentials is capped for chromium derivatives. As an alternative, Google is working on an update to chrome.identity that will work for chromium derivatives. Hoping this lands upstream soon: https://chromium-review.googlesource.com/c/chromium/src/+/2704571

@mastino21
Copy link

I still face this login problem in Keep extension and in Drive too (Save to Drive extension).

@nickgroverx
Copy link

I did these two and it worked for me:

  1. Allow google login for extensions, and
  2. Allow all cookies.

@Excess
Copy link

Excess commented May 27, 2021

Still not working as of May 27th, Brave Version 1.25.68 Chromium: 91.0.4472.77 (Official Build) (64-bit)

  • Allow Google login for extensions is ON
  • Brave's SHIELDS are completely DISABLED (no blocking of trackers, cookies, scripts whatsoever)
  • Extension that can't login in is listed as allowed on myaccount.google.com/permissions

I hope Google uncaps Google oauth credentials for Chromium soon, this is the only thing stopping me from fully migrating to Brave at work too.

@mastino21
Copy link

It works for me. Version 1.24.86 Chromium: 90.0.4430.212 (Build ufficiale) (a 64 bit) for Linux (Debian).

@mastino21
Copy link

mastino21 commented May 30, 2021

New update, actually something strange happens. I use multiple Brave profiles with multiple google accounts. As I wrote a few days ago, in one profile everything works (save to Google keep and google drive). In another Brave profile -with exactly the same browser settings- no way, I can't sign-in at all to the extensions: when I sign in I get redirected to google.com and I am signed in but if I click the extension button I am not actually signed in there.

New version for both profiles: Versione1.25.68 Chromium: 91.0.4472.77 (64 bit)

EDIT: maybe I have found the rootcause. It's due to a google cookie "user_id" missing from the profile where extensions do not work.
Here google cookies of the OK profile: https://imgur.com/q3U5RKF.png
Here google cookies of the profile not working: https://imgur.com/bjRvKgU.png

all cookie settings are the same on brave settings so I wonder what prevents google in the not working profile to store that cookie.

@jwashburn
Copy link

I'm having this issue too. Keep extension does nothing when I click "Sign in." Tried all the steps above and it still doesn't work. Following this issue now.

@jumde jumde removed their assignment Sep 14, 2021
@bsclifton
Copy link
Member

Closing as duplicate of #15754

@bsclifton bsclifton added the closed/duplicate Issue has already been reported label May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. regression
Projects
None yet
Development

No branches or pull requests

10 participants