Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave://welcome modal has an 8px border around it #14137

Closed
bsclifton opened this issue Feb 12, 2021 · 5 comments · Fixed by brave/brave-core#7957
Closed

brave://welcome modal has an 8px border around it #14137

bsclifton opened this issue Feb 12, 2021 · 5 comments · Fixed by brave/brave-core#7957

Comments

@bsclifton
Copy link
Member

Description

White 8px border is added to brave://welcome

Noticed on 1.22.22 by @LaurenWags ; was not present on 1.22.19.

Suspected PR that broke this:
brave/brave-core#7919

Steps to Reproduce

  1. Install 1.22.22
  2. Visit brave://welcome

Actual result:

image

Expected result:

No white 8 pixel border

Reproduces how often:

100%

Brave version (brave://version info)

1.22.22

Version/Channel Information:

Nightly

  • Can you reproduce this issue with the current release? n
  • Can you reproduce this issue with the beta channel? n
  • Can you reproduce this issue with the nightly channel? y
@Miyayes
Copy link
Collaborator

Miyayes commented Feb 13, 2021

Seems to extend beyond brave://welcome. CSS appears broken on all other interfaces as well (e.g., brave://rewards).

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 15, 2021

This issue is happening for brave://wallet also - Version 1.22.22 Chromium: 89.0.4389.40

image

@LaurenWags
Copy link
Member

@GeetaSarvadnya try a newer Nightly like 1.22.24

@GeetaSarvadnya
Copy link

Working fine in Windows 10 x64 - Version 1.22.25 Chromium: 89.0.4389.48

brave://welcome
image

brave://rewards
image

brave://wallet
image

@stephendonner
Copy link

Verified FIXED on nightly using

Brave 1.22.34 Chromium: 89.0.4389.48 (Official Build) nightly (x86_64)
Revision 0fe3c4589a6cf5ce719d167834dfa9cd8978937a-refs/branch-heads/4389@{#873}
OS macOS Version 11.2.1 (Build 20D74)

I checked dark and light versions of brave://welcome, as well as brave://rewards and brave://wallet panels.

Screenshots: Screen Shot 2021-02-18 at 2 29 42 PM Screen Shot 2021-02-18 at 2 29 56 PM Screen Shot 2021-02-18 at 2 30 17 PM Screen Shot 2021-02-18 at 2 30 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants