Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on Rewards settings from BAT drop down resets to zero on chrome://rewards #1427

Closed
GeetaSarvadnya opened this issue Oct 4, 2018 · 3 comments · Fixed by brave/brave-core#576

Comments

@GeetaSarvadnya
Copy link

Description

Click on Rewards settings from BAT drop down resets to zero on chrome://rewards

Steps to Reproduce

  1. Open brave with clean profile
  2. Enable Rewards from welcome page
  3. Claim grants
  4. Click on "Brave Rewards" triangle icon (displayed next to shield icon)
  5. Click on Rewards settings

Actual result:

Click on Rewards settings from BAT drop down resets to zero

0 5 11_rewards

Expected result:

Wallet BAT value should not reset

Reproduces how often:

100%

Brave version (chrome://version info)

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Windows

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? - No
  • Does it reproduce on browser-laptop? - No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional Information

@kjozwiak @LaurenWags @srirambv @btlechowski

@kjozwiak
Copy link
Member

kjozwiak commented Oct 4, 2018

Reproduced on macOS 10.13.6 x64 using the above STR. I think it's due to having two chrome://rewards opened. Example:

  • make sure you only have one chrome://rewards/ tab opened
  • within the same tab, click on the BAT icon in the URL bar and select Rewards Settings
  • a new chrome://rewards/ opens with 00.00(attempt refreshing this tab, you'll still get00.00`
  • switch over to the first tab and you'll see the correct amount even after refreshing
  • close the first tab that is correctly displaying the right BAT value and now refresh the second chrome://rewards/ tab. You'll finally see the correct BAT amount listed.

The above is reproducible whenever you have a balance, doesn't necessarily have to be a grant.

@jasonrsadler
Copy link

jasonrsadler commented Oct 5, 2018

@kjozwiak Confirm. Happening with more than one rewards page open.

@srirambv
Copy link
Contributor

srirambv commented Oct 11, 2018

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux
  • Verified Wallet balance showed correctly on two instances of chrome://rewards page

Verified passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X
  • Verified Wallet balance showed correctly on two instances of chrome://rewards page

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows
  • Verified Wallet balance showed correctly on two instances of chrome://rewards page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment