Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sync] Reset progress marker for data types to recover from permanent TRANSIENT and CONFLICT errors #14681

Closed
AlexeyBarabash opened this issue Mar 12, 2021 · 0 comments · Fixed by brave/brave-core#8201
Assignees
Labels
feature/new-metric Proposing a new metric for Privacy Preserving Product Analytics (P3A) feature/sync OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude

Comments

@AlexeyBarabash
Copy link
Contributor

Similar to #13960, but less heavy solution.

There are a lot of cases cases where sync stops to transfer data because of status
#11714, https://www.reddit.com/r/IAmA/comments/l2tvx1/we_are_brian_bondy_cofounder_and_cto_of_the_brave/gkjtwr7?utm_source=share&utm_medium=web2x&context=3, I saw that on my computer and @jsecretan reported he saw that also.

We don't know why this happens, but somehow server gets wrong data, for example when client tries to create the object with already exists on the server.

So this issue is to make changes to client that on several CONFLICT or TRANSIENT error the client re-fetched all the record for the failing type from the beginning and fixed its state.

@AlexeyBarabash AlexeyBarabash added feature/sync OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 12, 2021
@AlexeyBarabash AlexeyBarabash self-assigned this Mar 12, 2021
@AlexeyBarabash AlexeyBarabash changed the title [Sync] Reenable data types to recover from permanent TRANSIENT and CONFLICT errors [Sync] Reset progress marker for data types to recover from permanent TRANSIENT and CONFLICT errors Mar 15, 2021
@iefremov iefremov added the feature/new-metric Proposing a new metric for Privacy Preserving Product Analytics (P3A) label Mar 19, 2021
@AlexeyBarabash AlexeyBarabash added this to the 1.24.x - Nightly milestone Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/new-metric Proposing a new metric for Privacy Preserving Product Analytics (P3A) feature/sync OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants