Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave News customize button in some cases causes the Settings icon to go to Customize Dashboard instead of brave://settings #15221

Closed
Dzheky opened this issue Apr 11, 2021 · 3 comments · Fixed by brave/brave-core#8830

Comments

@Dzheky
Copy link

Dzheky commented Apr 11, 2021

Brave News customize button when scrolling up and down in some cases causes Settings/Bookmarks/History icons to go to the Customize Dashboard screen instead of brave://settings, brave://bookmarks, brave://history. The customize button interaction might be lingering after the scroll.

Description

The Customise button covers the bottom right icons when you scroll down and up.
2021-04-11 12 27 23

Steps to Reproduce

  1. Open new tab
  2. Scroll down until the Customise button appears in bottom right corner.
  3. Scroll up again until the Customise button disappears and try to click settings icon in the bottom right corner.

Actual result:

Customise dashboard opens.

Expected result:

Open settings.

Reproduces how often:

All the time.

Brave version (brave://version info)

Version 1.22.71 Chromium: 89.0.4389.114 (Official Build) (x86_64)

  • Can you reproduce this issue with the current release?
    Yes
  • Can you reproduce this issue with the beta channel?
    Yes
  • Can you reproduce this issue with the nightly channel?
    Yes
@Dzheky
Copy link
Author

Dzheky commented Apr 11, 2021

I will try to fix this if you don't mind

@Dzheky
Copy link
Author

Dzheky commented Apr 19, 2021

Can somebody review my PR for this, please?

@petemill petemill added this to the 1.26.x - Beta milestone May 19, 2021
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 1, 2021
@stephendonner
Copy link

Verified FIXED using

Brave 1.26.47 Chromium: 91.0.4472.77 (Official Build) beta (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)

I installed 1.22.71 to understand the issue, and once I did:

Steps:

  1. new profile
  2. opened a new-tab page
  3. scrolled down
  4. opted in to Brave News
  5. scrolled back up
  6. clicked on each of the icons alongside the Customize link, and ensured they opened Settings, Bookmarks, and History, respectively
example example example
Screen Shot 2021-06-01 at 1 05 48 PM Screen Shot 2021-06-01 at 1 05 38 PM Screen Shot 2021-06-01 at 1 05 28 PM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 1, 2021
@rebron rebron added the bug label Jun 21, 2021
@rebron rebron changed the title The Customise button covers the bottom right control icons Brave News customize button in some cases causes Settings icon to go to Customize Dashboard instead of brave://settings Jun 21, 2021
@rebron rebron changed the title Brave News customize button in some cases causes Settings icon to go to Customize Dashboard instead of brave://settings Brave News customize button in some cases causes the Settings/Bookmarks/History icon to go to Customize Dashboard instead of brave://settings Jun 21, 2021
@rebron rebron changed the title Brave News customize button in some cases causes the Settings/Bookmarks/History icon to go to Customize Dashboard instead of brave://settings Brave News customize button in some cases causes the Settings icon to go to Customize Dashboard instead of brave://settings Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants