Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locale and lang is leaked in Tor #15247

Open
btlechowski opened this issue Apr 12, 2021 · 1 comment
Open

Locale and lang is leaked in Tor #15247

btlechowski opened this issue Apr 12, 2021 · 1 comment
Labels
feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. feature/tor OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-Plan-Specified QA/Yes

Comments

@btlechowski
Copy link

It seems that locale and language is leaked

Steps to Reproduce

  1. Set Brave to Polish (PL) locale
  2. Open https://www.localeplanet.com/support/browser.html in Tor Window

Actual result:

Locale and lang is leaked in Tor
image

Expected result:

Locale and lang is not leaked in Tor

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.23.69 Chromium: 90.0.4430.61 (Official Build) (64-bit)
Revision dced74d4124b26b14126b611853d33512b60c7b6-refs/branch-heads/4430@{#1115}
OS Ubuntu 18.04 LTS

Version/Channel Information:

  • Can you reproduce this issue with the current release? y
  • Can you reproduce this issue with the beta channel? y
  • Can you reproduce this issue with the nightly channel? y

@brave/legacy_qa @jumde @diracdeltas
@btlechowski btlechowski added feature/tor feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. QA/Yes QA/Test-Plan-Specified OS/Desktop labels Apr 12, 2021
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jul 20, 2021
@btlechowski
Copy link
Author

Still reproducible

Brave 1.33.72 Chromium: 96.0.4664.35 (Official Build) nightly (64-bit)
Revision 8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}
OS Windows 7 Service Pack 1 (Build 7601.24544)

We leak: locale, language and timezone
image

@diracdeltas diracdeltas mentioned this issue Jul 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. feature/tor OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-Plan-Specified QA/Yes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rebron @btlechowski