-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log Rewards errors by default #15500
Comments
cc @PrivacyMatters. can we ensure that the errors don't include full URLs, PII, or sensitive info like tokens? for the feature flag, we should include something in the description that tells users that sensitive information may be written to disk if they turn this flag on. |
Flags in 'Experiments' brave://flags have 3 settings: default, enabled, disabled. What does the 'Default' setting do? What is its purpose? Will the the proposed flag be set to disabled? As per @diracdeltas what is the proposal re logging of URLs, ads viewed etc that may impact privacy if disclosed to Brave? |
@brave/legacy_qa we won't be able to verify the above on |
Removing |
Verified
|
Brave | 1.25.64 Chromium: 90.0.4430.212 (Official Build) beta (x86_64) |
---|---|
Revision | e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429} |
OS | macOS Version 11.3.1 (Build 20E241) |
Steps:
Error logging
- new profile, launched Brave using
--enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=5
- opened the Rewards panel and solved UGP captcha incorrectly
- went to
brave://rewards-internals
- selected the "Logs" tab and click "Refresh"
- confirmed that an error has been logged
- correctly solved UGP captcha
- one-time tipped via
laurenwags.github.io
- confirmed that non-error messages do not appear
example | example | example | example | example | example |
---|---|---|---|---|---|
Verbose logging
- new profile, launched Brave using
--enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=5
- went to
brave://flags
and setEnable Brave Rewards verbose logging
toEnabled
- relaunched Brave
- went to
brave://rewards-internals
- selected the
Logs
tab and clickedRefresh
- confirmed that detailed information - matching console output - was logged
- additionally, downloaded the logs and confirmed it matched
Logs
output
example | example | example |
---|---|---|
Verification passed on
Brave | 1.25.65 Chromium: 91.0.4472.57 (Official Build) (64-bit)
-- | --
Revision | e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS | Windows 10 OS Version 2004 (Build 19041.985)
Verified the test plan from brave/brave-core#8598
Confirmed error logs are shown in brave://rewards-internals when CAPTCHA test is incorrect
Confirmed non error logs should not appear in brave://rewards-internals when CAPTCH test is correct
Error logging
example | example | example | example | example | example |
---|---|---|---|---|---|
Verbose logging
Confirmed detailed logs is shown in brave://rewards-internals logs tab when Brave Rewards Verbose Logging
flag is enabled via brave://flags
example | example |
---|---|
Verification passed on
Brave | 1.25.65 Chromium: 91.0.4472.57 (Official Build) (64-bit) |
---|---|
Revision | e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6} |
OS | Ubuntu 18.04 LTS |
Verified the test plan from brave/brave-core#8598
Confirmed error logs are shown in brave://rewards-internals when CAPTCHA test is incorrect
Confirmed non error logs should not appear in brave://rewards-internals when CAPTCH test is correct
Error logging
example | example | example | example | example | example |
---|---|---|---|---|---|
Verbose logging
Confirmed detailed logs is shown in brave://rewards-internals logs tab when Brave Rewards Verbose Logging
flag is enabled via brave://flags
example | example |
---|---|
Verification passed on OnePlus 6T with Android 10 running 1.25.66 x64 build
Verification passed on Samsung Tab A with Android 10 running 1.25.66 x64 build
Logged #16061 |
Currently, the rewards log must be enabled using a command-line flag. When enabled, it will log at "verbose" level, which includes URL responses and other arbitrary data. In order to provide a better experience for diagnosing rewards issues:
The text was updated successfully, but these errors were encountered: