Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the IPFS onboarding page link per a privacy review #15829

Closed
bbondy opened this issue May 13, 2021 · 3 comments · Fixed by brave/brave-core#8798
Closed

Change the IPFS onboarding page link per a privacy review #15829

bbondy opened this issue May 13, 2021 · 3 comments · Fixed by brave/brave-core#8798

Comments

@bbondy
Copy link
Member

bbondy commented May 13, 2021

Learn more link on the IPFS onboarding interstitial page links to
https://support.brave.com/hc/en-us/sections/360010974932-InterPlanetary-File-System-IPFS- but @PrivacyMatters notes it should instead link to to https://support.brave.com/hc/en-us/articles/360051406452-How-does-IPFS-Impact-my-Privacy-

@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels May 13, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 13, 2021
@spylogsster
Copy link

changed for brave://settings/ipfs and for onboarding page

@stephendonner
Copy link

stephendonner commented May 14, 2021

Verified FIXED using

Brave 1.26.21 Chromium: 91.0.4472.57 (Official Build) nightly (x86_64)
Revision e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS macOS Version 11.3.1 (Build 20E241)

Confirmed that the Learn more link in the IPFS interstitial page goes to https://support.brave.com/hc/en-us/articles/360051406452-How-does-IPFS-Impact-my-Privacy- and the Learn more link in brave://settings/ipfs does the same.

interstitial brave://settings//ipfs
link-update Screen Shot 2021-05-14 at 1 01 19 PM

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.26.47 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
--- | ---
Revision | 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS | Windows 10 OS Version 2009 (Build 19042.1023)
  • ensured that clicking on Learn more via the IPFS interstitial page opens https://support.brave.com/hc/en-us/articles/360051406452-How-does-IPFS-Impact-my-Privacy- in a new tab without issues
  • ensured that clicking on Learn more under Method to resolve IPFS resources via brave://settings/ipfs opens https://support.brave.com/hc/en-us/articles/360051406452-How-does-IPFS-Impact-my-Privacy- in a new tab without issues

IPFS interstitial

Example Example
image image

brave://settings/ipfs

Example Example
image image

Verification passed on

Brave 1.26.45 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS Ubuntu 18.04 LTS

Confirmed that the Learn more link in the IPFS interstitial page goes to https://support.brave.com/hc/en-us/articles/360051406452-How-does-IPFS-Impact-my-Privacy- and the Learn more link in brave://settings/ipfs does the same.

image image

@srirambv
Copy link
Contributor

srirambv commented Jun 1, 2021

Verification passed on OnePlus 6T with Android 10 running 1.26.46 x64 Beta Build

  • Verified Learn more on IPFS interstitial page points to https://support.brave.com/hc/en-us/articles/360051406452-How-does-IPFS-Impact-my-Privacy-
Android.ARM.IPFS.LInk.mp4

Verification passed on Samsung Tab A with Android 10 running 1.26.46 x64 Beta Build

  • Verified Learn more on IPFS interstitial page points to https://support.brave.com/hc/en-us/articles/360051406452-How-does-IPFS-Impact-my-Privacy-
Android.Tab.IPFS.Link.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants