Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 91.0.4472.57 to Chromium 91.0.4472.70. #15973

Closed
mkarolin opened this issue May 19, 2021 · 3 comments · Fixed by brave/brave-core#8870 or #15980
Closed

Upgrade from Chromium 91.0.4472.57 to Chromium 91.0.4472.70. #15973

mkarolin opened this issue May 19, 2021 · 3 comments · Fixed by brave/brave-core#8870 or #15980

Comments

@mkarolin
Copy link
Contributor

mkarolin commented May 19, 2021

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/91.0.4472.57..91.0.4472.70?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

Additional checks:

No specific code changes in Brave (only line number changes in patches).

@mkarolin mkarolin added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop labels May 19, 2021
@mkarolin mkarolin self-assigned this May 19, 2021
@mkarolin mkarolin changed the title Upgrade from Chromium 91.0.4472.57 to Chromium 91.0.4472.69. Upgrade from Chromium 91.0.4472.57 to Chromium 91.0.4472.70. May 19, 2021
@LaurenWags
Copy link
Member

@brave/legacy_qa please test "Desktop Affected Areas" listed in #14848 (comment)

@LaurenWags
Copy link
Member

LaurenWags commented May 24, 2021

Verification in progress with

Brave | 1.25.66 Chromium: 91.0.4472.70 (Official Build) (x86_64)
-- | --
Revision | fe095368270a32c92959403754bf6fd357dd9953-refs/branch-heads/4472@{#1172}
OS | macOS Version 10.15.7 (Build 19H1030)

Verified "Desktop Affected Areas" listed under #14848 (comment)

Confirmed the version number displays in UI

Version Number

Confirmed components did not show "Update Error"/seem to have issues updating

Example Example
components1 components2

Spot checked brave://settings and brave://extensions to confirm UI looked as expected

Example Example
settings extensions

Confirmed the page info bubble displayed as expected

Example Example Example
1 2 3

Confirmed the profile avatar button displayed as expected when there was more than one profile

Example Example
first second

Confirmed ad notifications are still received as expected.

Also confirmed that I am rewarded for the ad notification views.
Confirmed system ad notifications are used, not custom ad notifications.

Example Example Example
Screen Shot 2021-05-24 at 3 30 29 PM Screen Shot 2021-05-24 at 3 31 03 PM Screen Shot 2021-05-24 at 3 30 50 PM

Verification passed on

Brave 1.25.66 Chromium: 91.0.4472.70 (Official Build) (64-bit)
Revision fe095368270a32c92959403754bf6fd357dd9953-refs/branch-heads/4472@{#1172}
OS Ubuntu 18.04 LTS

Verified "Desktop Affected Areas" listed under #14848 (comment)

Confirmed the version number displays in UI

image

Confirmed components did not show "Update Error"/seem to have issues updating

image

Spot checked brave://settings and brave://extensions to confirm UI looked as expected

Example Example
image image

Confirmed the page info bubble displayed as expected

image image

Confirmed the profile avatar button displayed as expected when there was more than one profile

image image

Confirmed ad notifications are still received as expected.

Also confirmed that I am rewarded for the ad notification views.
Confirmed system ad notifications are used, not custom ad notifications.

Example Example Example
image image image

Verification passed on


<!--StartFragment-->
Brave | 1.25.66 Chromium: 91.0.4472.70&nbsp;(Official Build)&nbsp;(64-bit)
-- | --
Revision | fe095368270a32c92959403754bf6fd357dd9953-refs/branch-heads/4472@{#1172}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.985)

<!--EndFragment-->

Verified "Desktop Affected Areas" listed under #14848 (comment)

Confirmed the version number displays in UI

Example Example
image image

Confirmed components did not show "Update Error"/seem to have issues updating

Example Example
image image

Spot checked brave://settings and brave://extensions to confirm UI looked as expected

Example Example
image image

Confirmed the page info bubble displayed as expected

Example Example Example
image image image

Confirmed the profile avatar button displayed as expected when there was more than one profile

Example Example
image image

Confirmed ad notifications are still received as expected.

Also confirmed that I am rewarded for the ad notification views.
Confirmed system ad notifications are used, not custom ad notifications.

Example Example Example
image image image

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.25.66 x64 build

Version number display in UI

About Brave

OnePlus 6T(Android 10) Samsung Tab A (Android 10)

chrome://version

OnePlus 6T(Android 10) Samsung Tab A (Android 10)
Components update
OnePlus 6T(Android 10) Samsung Tab A (Android 10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment