Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share local file/dir using IPFS does not work on desktop #16020

Closed
spylogsster opened this issue May 21, 2021 · 3 comments · Fixed by brave/brave-core#8893
Closed

Share local file/dir using IPFS does not work on desktop #16020

spylogsster opened this issue May 21, 2021 · 3 comments · Fixed by brave/brave-core#8893

Comments

@spylogsster
Copy link

spylogsster commented May 21, 2021

Second part of #15935
Not all cases were handled in last PR

Description + Steps to Reproduce

  • Start node and try to import without IPNS keys

Actual result:

Nothing happens, no error in console

Expected result:

File/dir picker is opened

@stephendonner
Copy link

Verified PASSED using the testplan from #14770 (comment); see there for detailed steps of the below tests. Tested with build

Brave 1.27.10 Chromium: 91.0.4472.70 (Official Build) nightly (x86_64)
Revision fe095368270a32c92959403754bf6fd357dd9953-refs/branch-heads/4472@{#1172}
OS macOS Version 11.3.1 (Build 20E241)

Also confirmed:

  • no crashes
  • no IPFS-shared files appeared in either the "shelf" on the browser toolbar, or the Downloads window; just their original, downloaded sources, as expected
CNN (directory) CNN (file) Vincent Van Goh (file) The Maltese Falcon (file) Downloads window
Screen Shot 2021-05-21 at 3 47 43 PM Screen Shot 2021-05-21 at 3 53 48 PM Screen Shot 2021-05-21 at 3 37 04 PM Screen Shot 2021-05-21 at 3 34 26 PM Screen Shot 2021-05-21 at 3 52 00 PM

CNN page's directory share link: https://dweb.link/ipfs/QmPThhLyadq1qfMp2ZDG3Qf8gCkCURuPgT9JuAGzUy3Hvq?filename=CNN+-+Breaking+News%2C+Latest+News+and+Videos_files

Vincent Van Goh page share link: https://bafybeiec4exjpqpkcoyh7eener6mhoeijhuj5es5qdz5dt7ei4y46knzty.ipfs.dweb.link/?filename=Vincent+van+Gogh+-+Wikipedia.html

The Maltese Falcon file share link: https://bafybeiepa2nep2hips6xlphsj6fg4uuxa2eicq4o3rkfke7njyo5veyc4a.ipfs.dweb.link/QmNbBjvpPRL7WwCorwCCawnjNCFDuWBBAr3rJWq1G3musS

@kjozwiak
Copy link
Member

Going to remove the QA Pass-macOS as the above was checked on Nightly so brave/brave-core#8901 can be uplifted. Thanks for running through the above on a Friday night @StephenBass 👍

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 27, 2021
@stephendonner
Copy link

Verified PASSED using the testplan from #14770 (comment) with build

Brave 1.26.43 Chromium: 91.0.4472.77 (Official Build) beta (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)
CNN dir CNN file Maltese Falcon video Vincent Van Gogh page Downloads window brave-imports dir
Screen Shot 2021-05-27 at 12 18 02 PM Screen Shot 2021-05-27 at 12 16 54 PM Screen Shot 2021-05-27 at 11 55 39 AM Screen Shot 2021-05-27 at 11 57 12 AM Screen Shot 2021-05-27 at 12 01 02 PM Screen Shot 2021-05-27 at 12 16 40 PM

Confirmed the following:

  • all imports worked, without errors
  • file content was intact
  • no crashes while downloading/importing/loading
  • no IPFS-shared files appeared in either the "shelf" on the browser toolbar, or the Downloads window; just their original, downloaded sources, as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants