Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN panel (logged into Brave Premium) #17246

Closed
Tracked by #15804
bsclifton opened this issue Jul 29, 2021 · 2 comments · Fixed by brave/brave-core#9730
Closed
Tracked by #15804

VPN panel (logged into Brave Premium) #17246

bsclifton opened this issue Jul 29, 2021 · 2 comments · Fixed by brave/brave-core#9730
Assignees
Labels
feature/vpn OS/Desktop premium All issues related to Brave Premium priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@bsclifton
Copy link
Member

bsclifton commented Jul 29, 2021

Description

Clicking on the button (see #17235) should create a bubble / popup that shows some basic VPN settings:

  • Toggle on/off
  • Server selection

Note: the button itself is behind the VPN feature flag.

image

Gradient toggle changes color like iOS/Android Shields toggle:

image

Challenges

  • The user would only be shown this if they are logged into Brave Premium already
  • If the user is not logged in yet, we'll need to show a different panel (see VPN panel (not logged into Brave Premium) #17249)
  • Issue TBD with details about how to detect if logged in or not logged in

Assets

Figma: https://www.figma.com/file/qtMYwoj3JWJO5xzwLt6j2f/?node-id=0%3A1

@bsclifton bsclifton changed the title VPN panel VPN panel (logged in) Jul 29, 2021
@bsclifton bsclifton changed the title VPN panel (logged in) VPN panel (logged into Brave Premium) Jul 29, 2021
@bsclifton
Copy link
Member Author

bsclifton commented Jul 29, 2021

Regions shown can be retrieved here:
https://github.com/brave/brave-core/blob/9cc43e2c1b4b5cc84a61baba2fe948ef18d5276c/components/brave_vpn/brave_vpn_service.cc#L93-L99

We'd need to store a profile preference for the person's current location. We can look at iOS for logic around setting a default location (how is this done?)

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jul 29, 2021
@nullhook
Copy link

nullhook commented Aug 2, 2021

We need to change the current UX. The dropdown for country selection will be clipped when it's rendered in a panel. Perhaps a list that can be navigated back and forth? The settings dropdown will also be clipped within the panel so this needs a diff UX as well.

I know the settings option is just a placeholder. However, we'll need options to show more information on a separate page brave://vpn if the user wanted to see for ex, logs, history, connection details, stats, etc. (future usecase)

cc @karenkliu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/vpn OS/Desktop premium All issues related to Brave Premium priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants