Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave ads 10s landed should check for target URL within redirect chain #17662

Closed
tmancey opened this issue Aug 24, 2021 · 1 comment · Fixed by brave/brave-core#9840
Closed

Comments

@tmancey
Copy link
Contributor

tmancey commented Aug 24, 2021

Brave ads should transfer after 10 seconds if the tab for the ad is visible and the host or domain matches any host or domain from the redirect chain

@btlechowski
Copy link

Verification passed on

Brave 1.30.68 Chromium: 93.0.4577.63 (Official Build) beta (64-bit)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/internal/issues/810

ads landed 301 redirect

Verified ad was transferred

[15451:15451:0920/164832.379527:VERBOSE1:ads_impl.cc(842)] Transfer ad for http://test.greenbytes.de/tech/tc/httpredirects/t301loc.asis in 0 hours, 0 minutes, 10 seconds at 4:48 PM
[15451:15451:0920/164842.384256:VERBOSE6:ad_transfer.cc(116)] Successfully logged transferred ad event

Verified successfully redeemed unblinded token for landed

[15451:15451:0920/164844.188051:VERBOSE1:confirmations.cc(251)] Successfully redeemed unblinded token with confirmation id 122f9cb7-1cbf-4964-ac77-35391b65ef2b, creative instance id de8274a9-716b-4340-afa1-9bfa52289077 and landed

ads landed 307 redirect

Verified ad was transferred

[13912:13912:0920/160229.866107:VERBOSE1:ads_impl.cc(846)] Transferred ad for http://test.greenbytes.de/tech/tc/httpredirects/t307loc.asis
[13912:13912:0920/160229.866009:VERBOSE6:ad_transfer.cc(116)] Successfully logged transferred ad event

Verified successfully redeemed unblinded token for landed

[13912:13912:0920/160239.776956:VERBOSE1:confirmations.cc(251)] Successfully redeemed unblinded token with confirmation id 35dbe479-cc85-4306-ba06-e72b3f3605e3, creative instance id de8274a9-716b-4340-afa1-9bfa52289077 and landed

ads landed 308 redirect

Verified ad was transferred

[5857:5857:0920/214325.206120:VERBOSE6:ad_transfer.cc(116)] Successfully logged transferred ad event
[5857:5857:0920/214325.206165:VERBOSE1:ads_impl.cc(846)] Transferred ad for http://test.greenbytes.de/tech/tc/httpredirects/t308loc.asis

Verified successfully redeemed unblinded token for landed

[5857:5857:0920/214325.845119:VERBOSE1:confirmations.cc(251)] Successfully redeemed unblinded token with confirmation id ff57cdf7-d4e3-4de1-be39-a64f1c2d18cf, creative instance id 9c24b513-6748-40a6-add2-e980b3ec3234 and landed

ads landed no redirect

Verified ad was transferred

[6930:6930:0920/220700.167239:VERBOSE1:ads_impl.cc(842)] Transfer ad for https://brave.com/ 
[6930:6930:0920/220710.162830:VERBOSE6:ad_transfer.cc(116)] Successfully logged transferred ad event
[6930:6930:0920/220710.162907:VERBOSE1:ads_impl.cc(846)] Transferred ad for https://brave.com/

Verified successfully redeemed unblinded token for landed

[6930:6930:0920/220710.751474:VERBOSE1:confirmations.cc(251)] Successfully redeemed unblinded token with confirmation id 2e08b021-b7ad-47f4-a83a-64ac2521161f, creative instance id 9c24b513-6748-40a6-add2-e980b3ec3234 and landed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants