Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac - Extensions do not load on high DPI display when a low DPI display is also connected (and is the primary display) #17897

Open
tallpants opened this issue Sep 7, 2021 · 4 comments
Labels
feature/extensions OS/Desktop OS/macOS priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@tallpants
Copy link

tallpants commented Sep 7, 2021

Description

On macOS, when multiple displays are connected with different DPIs, extensions do not load when the browser is on the high DPI display, but they load when the browser window is on the low DPI display. This is when the low DPI display is set as the "primary" display.

The tiny bit of the extension that does load also seems to be in low DPI. However I'm not able to interact with it in any way.

For reference I'm seeing this when having a 4K display (scaled to look like 2560x1440 in macOS's settings), and a 1080p display connected, and this seems to be happening with extension that opens its own window (tried with Bitwarden and uBlock Origin).

Steps to Reproduce

  1. Have a mac with both a high DPI and low DPI display.
  2. Make the low DPI display the primary display.
  3. Install any extension with it's own window (uBlock Origin fits).
  4. Try to open the extension window when the browser is on the high DPI display.

Actual result:

Opening the extension on the low DPI (1080p) display:

Screenshot 2021-09-07 at 12 07 46 PM

Opening the extension on the high DPI (4K display):

Screenshot 2021-09-07 at 12 05 52 PM

Expected result:

When the extension is opened with the browser window on the high DPI display, the extension should load correctly and display in high DPI.

Reproduces how often:

Every time.

Brave version (brave://version info)

Brave 1.29.77 Chromium: 93.0.4577.63 (Official Build) (x86_64)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS macOS Version 11.5.2 (Build 20G95)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Have not tried
  • Can you reproduce this issue with the nightly channel? Have not tried

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? The extension loads correctly on the latest Chrome, but it displays in low DPI.
@tallpants tallpants changed the title Mac - Extensions do not load on high DPI display when a low DPI display is also connected Mac - Extensions do not load on high DPI display when a low DPI display is also connected (and is the primary display) Sep 7, 2021
@rebron rebron added feature/extensions OS/macOS priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Sep 9, 2021
@rebron
Copy link
Collaborator

rebron commented Sep 9, 2021

@tallpants Are you consistently seeing this with Bitwarden and uBlock? Any other extensions? I think this maybe a chromium issue.

@rebron
Copy link
Collaborator

rebron commented Sep 9, 2021

@tallpants I want to double check you're using the version you mentioned on an Intel mac.
1.29.77 Chromium: 93.0.4577.63 (Official Build) (x86_64)

We have an arm64 specific version for M1 chips.


@rebron
Copy link
Collaborator

rebron commented Sep 9, 2021

Could you also try turning off Hardware Acceleration brave://settings/system and see if that fixes the issue you're seeing.

@tallpants
Copy link
Author

I've only tried it with uBlock and Bitwarden. On Chrome the extensions do load, but are displayed in low DPI even if the browser window is on the high DPI display.

I'm running on an Intel Mac yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/extensions OS/Desktop OS/macOS priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
Status: P5 backlog
Development

No branches or pull requests

2 participants