Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If amount is 0.0 BAT in Rewards panel summary view, do not show negative sign #17973

Closed
Miyayes opened this issue Sep 9, 2021 · 1 comment · Fixed by brave/brave-core#10047
Closed

If amount is 0.0 BAT in Rewards panel summary view, do not show negative sign #17973

Miyayes opened this issue Sep 9, 2021 · 1 comment · Fixed by brave/brave-core#10047
Assignees
@zenparsing
Labels
feature/rewards OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude rewards-2.0
Milestone
1.31.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Sep 9, 2021

Description

In Rewards Panel 2.0, if amount is 0.0, perhaps we shouldn't show a negative sign. It makes sense since these would be debits, but it looks a little scarier than just 0.0.

image

cc: @codybanxs
@Miyayes Miyayes changed the title If amount is 0.0 BAT in Rewards panel, do not show negative sign If amount is 0.0 BAT in Rewards panel summary view, do not show negative sign Sep 9, 2021
@zenparsing zenparsing self-assigned this Sep 9, 2021
@zenparsing zenparsing mentioned this issue Sep 10, 2021
Merged
24 tasks
@zenparsing zenparsing added this to the 1.31.x - Nightly milestone Sep 11, 2021
@stephendonner
Copy link

Verified PASSED using

Brave 1.31.37 Chromium: 93.0.4577.63 (Official Build) nightly (x86_64)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS macOS Version 11.6 (Build 20G165)

Confirmed no - sign when values are 0.00 .

Screen Shot 2021-09-13 at 16 04 38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/rewards OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude rewards-2.0
Projects
None yet
Milestone
1.31.x - Release
Development

Successfully merging a pull request may close this issue.

Add platform name to publisher title in Rewards panel brave/brave-core
3 participants
@stephendonner @zenparsing @Miyayes