Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto Wallet extension suddenly fails with 404 #18082

Open
DefiDebauchery opened this issue Sep 14, 2021 · 10 comments
Open

Crypto Wallet extension suddenly fails with 404 #18082

DefiDebauchery opened this issue Sep 14, 2021 · 10 comments
Labels
feature/ethereum-remote-client needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Desktop

Comments

@DefiDebauchery
Copy link

DefiDebauchery commented Sep 14, 2021

Description

At various times, the Crypto Wallet extension will become completely unavailable.
Strangely, only certain Browser Profiles will fail, while others do not.
Disabling and re-enabling the Wallet from the Extensions interface does not restore functionality.

EDIT: After posting, I compared versions and noted that somehow, the Wallets extension had been updated on the Profiles that were still working (1.0.34 at time of posting), but still a version behind in the ones that did not. I suppose the issue then becomes that updates are not being properly introduced to currently-running profiles.

Attempting to click "Update" on the extension does not work as you'd expect.

Steps to Reproduce

  1. Unknown, as it does not seem to happen in response to an action

Actual result:

Popup:
Screen Shot 2021-09-14 at 12 43 54 AM

Settings screen:
Screen Shot 2021-09-14 at 12 53 54 AM

Expected result:

Crypto Wallet/s never fails, even if updated mid-session.

Reproduces how often:

Old: No way to specifically reproduce that I know of, but anecdotally it does appear to happen more often when a wallet page is open for an extended time (e.g. a website has invoked the login popup while away from the computer)

New: May be in response to version updates of the Wallet.

Brave version (brave://version info)

Brave | 1.29.79 Chromium: 93.0.4577.63 (Official Build) (x86_64)
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | macOS Version 11.5.2 (Build 20G95)

Version/Channel Information:

Current

@srirambv
Copy link
Contributor

Can you elaborate on how many profiles you have and does each profile have wallet created? Are you trying to use the wallets on all profiles at the same time?

Does closing all profiles and restarting and launching brave://wallet update to the current stable release build?

@srirambv srirambv added feature/ethereum-remote-client needs-more-info The report requires more detail before we can decide what to do with this issue. labels Sep 14, 2021
@DefiDebauchery
Copy link
Author

DefiDebauchery commented Sep 14, 2021

Can you elaborate on how many profiles you have and does each profile have wallet created?

I have about 12 profiles. Profiles that were not in use (and one profile that was in use but apparently either did not have Wallet loaded, or it actually did what it was supposed to) updated fine. Two that were actively using Wallets (including one that had generated an unlock popup while the machine was idle) did not.

Most of my profiles do have a Wallet; I keep a Profile per EVM chain (Ethereum, BSC, Polygon, etc) so I don't have to switch networks, which interrupts things I may be doing.

Are you trying to use the wallets on all profiles at the same time?

I'm generally not using them at the same time; I will load a profile when needed and then close the window when I'm done.

Does closing all profiles and restarting and launching brave://wallet update to the current stable release build?

Simply closing the windows of those profiles did not update the Wallet; restarting Brave as a whole of course did.

@srirambv
Copy link
Contributor

Just circling back on this one sorry about the delay though.

Simply closing the windows of those profiles did not update the Wallet; restarting Brave as a whole of course did.

I did mean restart the entire Brave process by closing all the browser windows for all profiles. I assume the issue is fixed based on the above?

@DefiDebauchery
Copy link
Author

Yes, I had to restart the entire Brave process in order to regain access to the wallet extension. But I wouldn't call the issue "fixed"; the extension shouldn't be failing when Brave tries to upgrade.

@DefiDebauchery
Copy link
Author

Just a note that this happened again today, interrupting the ability to perform important transactions. I cannot restart Brave every time there's an update to the extension.

@DefiDebauchery
Copy link
Author

DefiDebauchery commented Oct 24, 2021

And again. @srirambv, can someone please take a look at this? This is incredibly disruptive and even dangerous if a transaction needs to be executed but cannot because the browser decided to shut the whole thing down over an failed update integration.

@srirambv
Copy link
Contributor

Sorry for missing this. FWIW there is no need to restart the browser process every time there is a extension update. You can force update the extension via brave://components and the newer version would download automatically (for the active profile). Since you have around 12! profiles, you will have to do it manually if not auto-updated.

@DefiDebauchery
Copy link
Author

Thank you for the response, @srirambv. Unfortunately, this does not seem to work for me. I clicked "Check for update" which flashes "Status - Update started" but then immediately displays "Component not updated". I don't seem to be able to get this to load the new component if the profile is active.

@srirambv
Copy link
Contributor

"Component not updated" means that its already at the latest version. What component version do you have in brave://components for Crypto Wallet? The current version is 1.0.36

@DefiDebauchery
Copy link
Author

It was 1.0.36.

I noticed that having multiple Profiles open, the components details synced among all profiles. So the issue isn't that Brave isn't applying the update in general, it's that it breaks for open Profiles.

Any profiles that were not currently using Wallets (i.e. fully closed) worked fine when attempting to use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/ethereum-remote-client needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Desktop
Projects
None yet
Development

No branches or pull requests

2 participants