Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When updating, always install latest update (or offer options) #18124

Open
tripleee opened this issue Sep 15, 2021 · 0 comments
Open

When updating, always install latest update (or offer options) #18124

tripleee opened this issue Sep 15, 2021 · 0 comments
Labels
feature/updater installer/omaha Issues for windows omaha installer OS/Desktop OS/macOS priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@tripleee
Copy link

Description

Just now, on MacOS Catalina, I had an update dialog box open since yesterday. I clicked "Install and Relaunch" ... only to have it throw up a new update dialog box when the update finished and the browser relaunched.

Could the "Install and Relaunch" logic be rerigged to at least offer to pull in the latest update, not just the one which triggered the dialog box?

I understand that the information in the dialog box may be obsolete by the time the user clicks, and so possibly there should be three options: "Review New Pending Updates" (only displayed when newer updates are available), "Cancel", and "Relaunch and Install Only This Update".

On the other hand, you would usually want to end up on the latest version, so perhaps this is a needless complication. It could very well be enough to display "Additional updates have arrived since the notification was displayed; they will be installed as well. If you want to review the changes, cancel and check for newest updates again."

Steps to Reproduce

  1. Receive a notification that a new version is available
  2. Wait for long enough that it's no longer the newest update
  3. Click "Relaunch and Install"

Actual result:

You are immediately prompted to install a newer update still.

Expected result:

Latest update installed. no more disruptions to your browser experience when the browser relaunches.

Reproduces how often:

Depending on how reluctant you are to take an update, these days, pretty easy to repro I would think.

Brave version (brave://version info)

Brave 1.29.81 Chromium: 93.0.4577.82 (Official Build) (x86_64)
Revision e3a25d9b9e2d0b728e045ec87c0aa4942aa46e4e-refs/branch-heads/4577@{#1237}
OS macOS Version 11.5.2 (Build 20G95)

(Probably something like 1.29.79 when this thing started.)

Version/Channel Information:

(Only tested current release.)

Other Additional Information:

  • Is the issue reproducible on the latest version of Chrome?

I haven't been able to check with official Chrome (I have no control over when it updates, as this is handled by my company's IT), but my understanding is no. I run Chrome Canary and rarely update, and yet it seems to not offer new updates immediately after.

Miscellaneous Information:

N/A

@bsclifton bsclifton added feature/updater installer/omaha Issues for windows omaha installer OS/macOS labels Sep 27, 2021
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/updater installer/omaha Issues for windows omaha installer OS/Desktop OS/macOS priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
Status: P5 Backlog / waiting upstream
Development

No branches or pull requests

3 participants