Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add restore from brave crypto wallets checkbox for 24-word mnemonic #18459

Closed
jamesmudgett opened this issue Sep 30, 2021 · 1 comment · Fixed by brave/brave-core#11833
Closed

Add restore from brave crypto wallets checkbox for 24-word mnemonic #18459

jamesmudgett opened this issue Sep 30, 2021 · 1 comment · Fixed by brave/brave-core#11833
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@jamesmudgett
Copy link

We should support import from Brave crypto wallets with legacy 24-word mnemonic into new Brave wallet on Android.

Needs checkbox similar to desktop.
Screenshot_20210921-105655

Desktop
Brave Wallet - My Crypto - account recovery
@jamesmudgett jamesmudgett added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Sep 30, 2021
@SergeyZhukovsky SergeyZhukovsky added priority/P4 Planned work. We expect to get to it "soon". QA/No release-notes/exclude labels Oct 22, 2021
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P4 Planned work. We expect to get to it "soon". labels Dec 29, 2021
@Pavneet-Sing Pavneet-Sing self-assigned this Jan 11, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Jan 12, 2022
Merged
25 tasks
@Pavneet-Sing Pavneet-Sing added this to the 1.36.x - Nightly milestone Jan 13, 2022
@srirambv
Copy link
Contributor

srirambv commented Feb 4, 2022

Verification passed on the following devices running 1.36.85 x64 Beta build

  • Verified able to import 24-word mnemonic
  • Verified when 24-word seed is typed in shows a checkbox for importing from legacy wallet
  • Verified selecting the checkbox restores the same wallet
  • Verified unselecting the checkbox and restoring creates a new wallet instead of restoring the wallet
  • Encountered #20884 & #20885
Oppo Reno 5 (Android 11) Samsung Tab A (Android 10)

@Pavneet-Sing Pavneet-Sing mentioned this issue Feb 11, 2022
Merged
25 tasks
@kjozwiak kjozwiak mentioned this issue Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): add restore legacy wallet option brave/brave-core
5 participants
@jamesmudgett @bbondy @Pavneet-Sing @SergeyZhukovsky @srirambv