Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up to #18184: Error when serving Brave News inline ads of parent-child category #18764

Closed
btlechowski opened this issue Oct 14, 2021 · 2 comments
Closed

Follow up to #18184: Error when serving Brave News inline ads of parent-child category #18764

btlechowski opened this issue Oct 14, 2021 · 2 comments
Assignees
@tmancey
Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.35.x - Release

Comments

@btlechowski
Copy link

btlechowski commented Oct 14, 2021 •
edited
Loading

Follow up to #18184 Brave news display ads/advertisers should round robin before showing the same ads

Error when serving Brave News inline ads of parent-child category. Round robin fails.

Important: untargeted and parent categories work as expected. Currently, all inline ads are of untargeted category.

Steps to Reproduce

  1. Follow Different advertisers - Ads in the same child category from https://github.com/brave/internal/issues/819

Actual result:

Error when serving ads
Round robin fails

[11684:11684:1014/121934.288279:VERBOSE1:inline_content_ad_serving.cc(68)] Ad serving version 1
[11684:11684:1014/121934.295157:VERBOSE1:eligible_inline_content_ads.cc(166)] Get eligible ads for parent-child segments:
[11684:11684:1014/121934.295247:VERBOSE1:eligible_inline_content_ads.cc(168)]   technology & computing-software
[11684:11684:1014/121934.295479:VERBOSE1:eligible_inline_content_ads.cc(168)]   personal finance-personal finance
[11684:11684:1014/121934.295537:VERBOSE1:eligible_inline_content_ads.cc(168)]   food & drink-vegetarian
[11684:11684:1014/121934.300028:VERBOSE2:ad_priority.h(32)] 3 ads with a priority of 1 in bucket 1
[11684:11684:1014/121934.300100:VERBOSE1:inline_content_ad_serving.cc(104)] Found 3 eligible ads
[11684:11684:1014/121934.300156:VERBOSE1:inline_content_ad_serving.cc(129)] Serving inline content ad:
  uuid: 5bc018b6-0092-485b-bab2-d0a48adb5edf
  creativeInstanceId: 0c400252-1a1d-486b-b4dc-e73a28377634
  creativeSetId: 1ce70642-d0c5-4dc2-89dc-b8f50ce68b91
  campaignId: 67ea6d21-c015-4ef5-ae53-3c22f8742256
  advertiserId: aa2e9ff6-8c3c-4cb2-b5e8-f416bb891ef1
  segment: technology & computing-software
  title: Ad BBB - child
  description: Tixl | Hamburg, Germany
  imageUrl: https://pcdn.brave.com/brave-ads/905726ff-c57c-5602-a7b6-a4140a3b31df.webp.pad
  dimensions: 900x750
  ctaText: Read now
  targetUrl: https://tixl.xyz/defi20
[11684:11684:1014/121934.312716:INFO:creative_inline_content_ads_database_table.cc(574)] Failed to get creative inline content ad
[11684:11684:1014/121934.313025:VERBOSE1:inline_content_ad.cc(56)] Failed to fire inline content ad event due to missing creative instance id 0c400252-1a1d-486b-b4dc-e73a28377634
[11684:11684:1014/121934.313071:VERBOSE1:ads_impl.cc(858)] Failed to fire inline content ad kServed event for uuid 5bc018b6-0092-485b-bab2-d0a48adb5edf and creative instance id 0c400252-1a1d-486b-b4dc-e73a28377634

Expected result:

No error. Round robin works

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.32.62 Chromium: 95.0.4638.40 (Official Build) nightly (64-bit)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @tmancey @jsecretan @rebron
@btlechowski btlechowski mentioned this issue Oct 14, 2021
Merged
24 tasks
@tmancey tmancey added this to the 1.35.x - Nightly milestone Dec 21, 2021
@tmancey tmancey added QA/Yes release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 21, 2021
@tmancey tmancey self-assigned this Dec 21, 2021
@tmancey
Copy link
Contributor

tmancey commented Dec 21, 2021

@btlechowski can you please retest this as the ad serving business logic has been rewritten since. Thanks

@tmancey tmancey closed this as completed Dec 21, 2021
@btlechowski
Copy link
Author

Verification passed on

Brave 1.35.85 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Ubuntu 18.04 LTS

Verified test plan from the description
Used catalog
inline - advertisers - child v9.txt

1st ad shown

[21690:21690:0117/005054.396137:VERBOSE1:eligible_inline_content_ads_v1.cc(40)] Get eligible inline content ads:
[21690:21690:0117/005054.397216:VERBOSE1:eligible_inline_content_ads_v1.cc(86)] Get eligible ads for parent-child segments:
[21690:21690:0117/005054.397250:VERBOSE1:eligible_inline_content_ads_v1.cc(88)]   technology & computing-software
[21690:21690:0117/005054.397281:VERBOSE1:eligible_inline_content_ads_v1.cc(88)]   technology & computing-technology & computing
[21690:21690:0117/005054.397300:VERBOSE1:eligible_inline_content_ads_v1.cc(88)]   business-business
[21690:21690:0117/005054.400412:VERBOSE2:ad_priority.h(32)] 2 ads with a priority of 1 in bucket 1
[21690:21690:0117/005054.400452:VERBOSE1:inline_content_ad_serving.cc(86)] Found 2 eligible ads
[21690:21690:0117/005054.400490:VERBOSE1:inline_content_ad_serving.cc(129)] Serving inline content ad:
  uuid: 46e63f9b-93a7-4ad4-9739-2ea258cc7c8c
  creativeInstanceId: 033a95ca-963b-460c-b203-8181346bd41c
  creativeSetId: 6c875e23-00ea-4f1b-805b-5d52559f96da
  campaignId: 8a5ca6f0-f919-461b-8bf2-4848e34ab616
  advertiserId: aa1d1cdb-ec45-42d4-86d0-ea353e1babd4
  segment: technology & computing-software
  title: Makita LF1000 Flip Over Saw
  description: Makita
  imageUrl: https://pcdn.bravesoftware.com/brave-ads/image-1.jpg.pad
  dimensions: 900x750
  ctaText: Learn more
  targetUrl: https://www.powertools2u.co.uk/makita-lf1000-flip-over-sawo
[21690:21690:0117/005054.400692:VERBOSE1:inline_content_ad_serving.cc(98)] Served inline content ad
[21690:21690:0117/005054.404139:VERBOSE3:inline_content_ad_event_served.cc(24)] Served inline content ad with uuid 46e63f9b-93a7-4ad4-9739-2ea258cc7c8c and creative instance id 033a95ca-963b-460c-b203-8181346bd41c
[21690:21690:0117/005054.417728:VERBOSE1:inline_content_ad_event_served.cc(32)] Successfully logged inline content ad served event

2nd ad shown

[22419:22419:0117/015218.103372:VERBOSE1:eligible_inline_content_ads_v1.cc(40)] Get eligible inline content ads:
[22419:22419:0117/015218.104757:VERBOSE1:eligible_inline_content_ads_v1.cc(86)] Get eligible ads for parent-child segments:
[22419:22419:0117/015218.104797:VERBOSE1:eligible_inline_content_ads_v1.cc(88)]   technology & computing-software
[22419:22419:0117/015218.104828:VERBOSE1:eligible_inline_content_ads_v1.cc(88)]   technology & computing-technology & computing
[22419:22419:0117/015218.104846:VERBOSE1:eligible_inline_content_ads_v1.cc(88)]   business-business
[22419:22419:0117/015218.106748:VERBOSE2:ad_priority.h(32)] 1 ads with a priority of 1 in bucket 1
[22419:22419:0117/015218.106927:VERBOSE1:inline_content_ad_serving.cc(86)] Found 1 eligible ads
[22419:22419:0117/015218.107038:VERBOSE1:inline_content_ad_serving.cc(129)] Serving inline content ad:
  uuid: 2bd0dbeb-05bb-4fe7-865c-89259f1bc18b
  creativeInstanceId: e4958d00-e35c-4134-a408-1fbcf274d5ae
  creativeSetId: 8b848823-c47f-43de-a753-2efa8dea6863
  campaignId: 07de7f05-ab32-4af0-a350-a1bce4427eac
  advertiserId: 93130af3-2def-4ecb-b836-b3772e73b3c9
  segment: technology & computing-software
  title: Staging - Inline Test 1
  description: Fung Brave News Inline Display Ad - mac/linux
  imageUrl: https://pcdn.brave.com/brave-ads/468beb93-2458-5d3e-8d7b-bc1f387d2e9b.webp.pad
  dimensions: 900x750
  ctaText: Work at Brave
  targetUrl: https://brave.com/careers
[22419:22419:0117/015218.107855:VERBOSE1:inline_content_ad_serving.cc(98)] Served inline content ad
[22419:22419:0117/015218.109244:VERBOSE3:inline_content_ad_event_served.cc(24)] Served inline content ad with uuid 2bd0dbeb-05bb-4fe7-865c-89259f1bc18b and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae
[22419:22419:0117/015218.119381:VERBOSE1:inline_content_ad_event_served.cc(32)] Successfully logged inline content ad served event

3rd ad shown after round robin (this was failing before)

[22733:22733:0117/025320.252218:VERBOSE1:eligible_inline_content_ads_v1.cc(40)] Get eligible inline content ads:
[22733:22733:0117/025320.253540:VERBOSE1:eligible_inline_content_ads_v1.cc(86)] Get eligible ads for parent-child segments:
[22733:22733:0117/025320.253606:VERBOSE1:eligible_inline_content_ads_v1.cc(88)]   technology & computing-software
[22733:22733:0117/025320.253664:VERBOSE1:eligible_inline_content_ads_v1.cc(88)]   technology & computing-technology & computing
[22733:22733:0117/025320.253699:VERBOSE1:eligible_inline_content_ads_v1.cc(88)]   business-business
[22733:22733:0117/025320.255779:VERBOSE1:seen_advertisers.h(30)] All inline_content_ad advertisers have been shown, so round robin
[22733:22733:0117/025320.255822:VERBOSE1:client.cc(446)] Resetting seen inline_content_ad advertisers
[22733:22733:0117/025320.255947:VERBOSE1:seen_ads.h(30)] All inline_content_ad ads have been shown, so round robin
[22733:22733:0117/025320.255967:VERBOSE1:client.cc(410)] Resetting seen inline_content_ads
[22733:22733:0117/025320.256036:VERBOSE2:ad_priority.h(32)] 2 ads with a priority of 1 in bucket 1
[22733:22733:0117/025320.256060:VERBOSE1:inline_content_ad_serving.cc(86)] Found 2 eligible ads
[22733:22733:0117/025320.256088:VERBOSE1:inline_content_ad_serving.cc(129)] Serving inline content ad:
  uuid: 4e0aabfd-4813-4aba-abef-cafa654b9ef2
  creativeInstanceId: 033a95ca-963b-460c-b203-8181346bd41c
  creativeSetId: 6c875e23-00ea-4f1b-805b-5d52559f96da
  campaignId: 8a5ca6f0-f919-461b-8bf2-4848e34ab616
  advertiserId: aa1d1cdb-ec45-42d4-86d0-ea353e1babd4
  segment: technology & computing-software
  title: Makita LF1000 Flip Over Saw
  description: Makita
  imageUrl: https://pcdn.bravesoftware.com/brave-ads/image-1.jpg.pad
  dimensions: 900x750
  ctaText: Learn more
  targetUrl: https://www.powertools2u.co.uk/makita-lf1000-flip-over-sawo
[22733:22733:0117/025320.256228:VERBOSE1:inline_content_ad_serving.cc(98)] Served inline content ad
[22733:22733:0117/025320.272502:VERBOSE3:inline_content_ad_event_served.cc(24)] Served inline content ad with uuid 4e0aabfd-4813-4aba-abef-cafa654b9ef2 and creative instance id 033a95ca-963b-460c-b203-8181346bd41c
[22733:22733:0117/025320.292163:VERBOSE1:inline_content_ad_event_served.cc(32)] Successfully logged inline content ad served event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.35.x - Release
Development

No branches or pull requests
2 participants
@tmancey @btlechowski