Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path names do not appear in address bar for IPNS addresses #18888

Closed
autonome opened this issue Oct 20, 2021 · 4 comments · Fixed by brave/brave-core#11085
Closed

Path names do not appear in address bar for IPNS addresses #18888

autonome opened this issue Oct 20, 2021 · 4 comments · Fixed by brave/brave-core#11085

Comments

@autonome
Copy link

Description

If you open an IPNS address and click around, paths do not appear in the address bar. If you open the IPFS address for the same website, paths do appear in the address bar

Steps to Reproduce

  1. Open ipns://docs.ipfs.io
  2. Click some items in the navigation bar

Actual result:

Paths do not appear in the address bar after the FQDN.

Expected result:

Paths are visible in the address bar after the FQDN.

Reproduces how often:

100%

Brave version (brave://version info)

Brave nightly Oct 20 2021

Version/Channel Information:

Reproduced on Nightly and Release channels

@lidel
Copy link

lidel commented Oct 20, 2021

Not sure how useful, but I confirmed this bug was present since 1.29.79+
It impacts IPFS Companion – our extension is unable to get content path for specific subpage, we are stuck at the root URI as well:

2021-10-20_16-43

However, if you hover on the link, you see the full path in the bottom left corner:

2021-10-20_16-43_1

Looks like something is not wired up for ipns://docs.ipfs.io/ (ipfs://bafybeied2n6vi4nmp5ynmv2hob4426l5q2pfcet3ilsvmxqhml34fgu4b4 works fine)

@autonome
Copy link
Author

So should add a regression test for this, since it used to work.

Yep I also noticed that hover links work fine, so looks like only the address bar code path (so far).

@lidel
Copy link

lidel commented Nov 10, 2021

I published a small demo under bafybeid2sz6646igfsciecr2cwcb7e2hxl6xewigxy3rjwgk6cbfmiiium to help with narrowing this down.

Clicking on cat names update the address bar via history.pushState. Tested in Brave 1.31.91 with different addresses:

  • 🍏 ipfs://bafybeid2sz6646igfsciecr2cwcb7e2hxl6xewigxy3rjwgk6cbfmiiium/demos/history/ – works as expected
  • 🍏 ipns://k51qzi5uqu5dgutdk6i1ynyzgkqngpha5xpgia3a5qqp4jsh0u4csozksxel2r/demos/history/ – works as expected
  • 💢 ipns://kittens-history-push-demo.aergia.eu/demos/history/ – broken (address in address bar does not get updated when clicking on links)

@stephendonner
Copy link

Verified PASSED using

Brave 1.34.37 Chromium: 96.0.4664.45 (Official Build) nightly (x86_64)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS macOS Version 11.6.1 (Build 20G224)

Steps:

  1. new profile
  2. launched Brave
  3. loaded ipns://docs.ipfs.io/
  4. clicked on various side-navigation anchors
  5. confirmed they showed up in the URL bar
  6. via brave://settings/ipfs toggled IPFS Companion to install it
  7. confirmed clicking on various side-navigation anchors reflected the anchors in the Companion, as well as the clipboard
  8. also confirmed same for various cat links on ipns://kittens-history-push-demo.aergia.eu/demos/history/
ipns://docs.ipfs.io/install/ipfs-desktop/#macos IPFS Companion clipboard fluffy socks
Screen Shot 2021-11-25 at 6 38 37 AM Screen Shot 2021-11-25 at 6 47 24 AM Screen Shot 2021-11-25 at 6 48 15 AM Screen Shot 2021-11-25 at 6 49 30 AM Screen Shot 2021-11-25 at 6 49 33 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment