Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Together should be Brave Talk in its card image #19220

Closed
stephendonner opened this issue Nov 3, 2021 · 2 comments · Fixed by brave/brave-core#10864
Closed

Brave Together should be Brave Talk in its card image #19220

stephendonner opened this issue Nov 3, 2021 · 2 comments · Fixed by brave/brave-core#10864

Comments

@stephendonner
Copy link

Description

Brave Together should be Brave Talk in its card image

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. open a new-tab page
  4. click on Edit Cards
  5. look at the title for Brave Talk's card

Actual result:

Reads Brave Together in the card's image

Screen Shot 2021-11-03 at 1 54 23 PM

Expected result:

It should read Brave Talk in the card's image

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@stephendonner
Copy link
Author

stephendonner commented Nov 3, 2021

So yeah, I botched the verification of that in #17250 (comment) 👎

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.33.69 Chromium: 96.0.4664.35 (Official Build) nightly (x86_64)
Revision 8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}
OS macOS Version 11.6.1 (Build 20G224)

Confirmed it reads Brave Talk in both the preview card and the actual card.

example example
Screen Shot 2021-11-08 at 9 25 46 AM Screen Shot 2021-11-08 at 9 25 50 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment