Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ethereum chain network dialog should list number of decimals too #19749

Closed
bbondy opened this issue Nov 26, 2021 · 1 comment · Fixed by brave/brave-core#11941
Closed

Add Ethereum chain network dialog should list number of decimals too #19749

bbondy opened this issue Nov 26, 2021 · 1 comment · Fixed by brave/brave-core#11941
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Nov 26, 2021

Details view for adding a network doesn't show Decimals: X from the payload, where X is a number like 18.
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 26, 2021
@bbondy bbondy added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 26, 2021
@Douglashdaniel Douglashdaniel self-assigned this Jan 20, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Jan 20, 2022
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.36.x - Nightly milestone Jan 21, 2022
@srirambv
Copy link
Contributor

srirambv commented Feb 4, 2022

Brave 1.36.83 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
19749-Linux.mp4
19749-Windows.mov
19749-macOS.mov

@LaurenWags LaurenWags mentioned this issue Mar 1, 2022
Closed
@kjozwiak kjozwiak mentioned this issue Mar 14, 2022
Closed
@bbondy bbondy removed the OS/Android Fixes related to Android browser functionality label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

Added Decimal Value to Add Network Panel brave/brave-core
3 participants
@bbondy @srirambv @Douglashdaniel