Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong log message for promoted content ad when not found in the catalog #19832

Closed
btlechowski opened this issue Nov 30, 2021 · 2 comments · Fixed by brave/brave-core#11377
Closed

Comments

@btlechowski
Copy link

It says new tab page ad instead of promoted content ad

Steps to Reproduce

  1. View a promoted content ad that is not included in the ads catalog

Actual result:

[INFO:creative_promoted_content_ads_database_table.cc(527)] Failed to get creative new tab page ad

Expected result:

[INFO:creative_promoted_content_ads_database_table.cc(527)] Failed to get creative for promoted content ad

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.33.83 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @tmancey @jsecretan

@btlechowski
Copy link
Author

QA/Blocked promoted content ads are not available on staging nor on production

@btlechowski
Copy link
Author

Verification passed on

Brave 1.35.85 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Ubuntu 18.04 LTS

Whitebox tested the PR. Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants