Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems with voting and creating spaces / proposals on snapshot.org Dapp #20282

Closed
bbondy opened this issue Jan 1, 2022 · 1 comment · Fixed by brave/brave-core#11720
Closed

Problems with voting and creating spaces / proposals on snapshot.org Dapp #20282

bbondy opened this issue Jan 1, 2022 · 1 comment · Fixed by brave/brave-core#11720
Assignees
@bbondy
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.34.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Jan 1, 2022 •
edited by srirambv
Loading

MM allows for typed data with uint* and int* types to have string values.

Snapshot a dapp for governance and voting on proposals does this. Instead of on chain it just signs data for voting.
https://snapshot.org/#/bbondy.eth/proposal/0xe8d6d011fd1ced4f7b9ef5de19dcd47ac728d9a3553fa60dcb73ecf6ad768b61 (edited)

Test Plan

  1. Restore a wallet that has BAT in it.
  2. Navigate to:
    https://snapshot.org/#/bbondy.eth/proposal/0x0a66e9ced204e81785b6e0be34abad7c246167e97d5f8de9eb3e7798cb3d7134
  3. Connect wallet
  4. Vote
  5. Sign data and make sure vote gets registered.
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jan 1, 2022
@bbondy bbondy self-assigned this Jan 1, 2022
@bbondy bbondy added feature/web3/wallet Integrating Ethereum+ wallet support priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 1, 2022
@bbondy bbondy mentioned this issue Jan 1, 2022
Merged
25 tasks
@bbondy bbondy added this to the 1.36.x - Nightly milestone Jan 2, 2022
This was referenced Jan 2, 2022
Merged
Merged
@bbondy bbondy changed the title sign typed data should accept string values for uint* and int* types Voting and creating spaces / proposals on snapshot.org Dapp was not working Jan 2, 2022
@bbondy bbondy changed the title Voting and creating spaces / proposals on snapshot.org Dapp was not working Problems with voting and creating spaces / proposals on snapshot.org Dapp Jan 2, 2022
@LaurenWags LaurenWags mentioned this issue Jan 4, 2022
Closed
@srirambv
Copy link
Contributor

srirambv commented Jan 5, 2022

Verification passed on

Brave 1.34.78 Chromium: 97.0.4692.71 (Official Build) (arm64)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS macOS Version 12.1 (Build 21C52)
  • Verified steps from issue description
  • Verified able to cast votes without issues. Confirmation

@kjozwiak kjozwiak mentioned this issue Jan 7, 2022
Closed
@bbondy bbondy mentioned this issue Feb 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.34.x - Release
Development

Successfully merging a pull request may close this issue.

Make signing methods more compatible with MetaMask brave/brave-core
3 participants
@bbondy @kjozwiak @srirambv