Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor rewards contribution flows for testability #20473

Closed
zenparsing opened this issue Jan 12, 2022 · 1 comment
Closed

Refactor rewards contribution flows for testability #20473

zenparsing opened this issue Jan 12, 2022 · 1 comment
Assignees
@zenparsing
Labels
dev-concern feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@zenparsing
Copy link

Rewards contribution flows implemented in bat-native-ledger are not currently written in an easily testable manner. The flows are only tested in browser tests which are notoriously flaky, and many have been disabled. Contribution flows should be restructured so that they can be tested with unit tests.
@zenparsing zenparsing self-assigned this Jan 12, 2022
@zenparsing zenparsing mentioned this issue Jan 12, 2022
Merged
25 tasks
@Miyayes Miyayes mentioned this issue Jan 26, 2022
Closed
@Miyayes Miyayes added priority/P2 A bad problem. We might uplift this to the next planned release. priority/P3 The next thing for us to work on. It'll ride the trains. dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop and removed OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. labels Feb 23, 2022
@zenparsing zenparsing mentioned this issue Apr 19, 2022
Closed
@zenparsing zenparsing added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels May 13, 2022
@Miyayes
Copy link
Collaborator

Miyayes commented Jan 20, 2023

Issue now too vague. Can file more specific issues.

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
dev-concern feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zenparsing @Miyayes