Bad confirmation error when saving ad in 30-day ads history

[btlechowski]

Follow up to #16005

Steps to Reproduce

1. Clean profile
2. Enable rewards and ads on staging
3. View a notification ad
4. Open 30-day ads history from brave://rewards
5. Save the ad
6. Check logs

note: also reproducible on production

Actual result:

Bad confirmation error in logs

[28698:28698:0203/024945.190057:VERBOSE1:redeem_unblinded_token.cc(55)] Redeem unblinded token
[28698:28698:0203/024945.191170:VERBOSE1:redeem_unblinded_token.cc(74)] CreateConfirmation
[28698:28698:0203/024945.191341:VERBOSE2:redeem_unblinded_token.cc(75)] POST /v2/confirmation/{confirmation_id}/{credential}
[28698:28698:0203/024945.191618:VERBOSE6:redeem_unblinded_token.cc(79)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v2/confirmation/c3585488-aad6-47c7-9dc6-dc033c31d81e/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlbnNcIjpbXCJIbHltOUcvTGdDdWFzNUFOR3YvK0tzb2JZZSs0bzRLaWVsZUcrZmRCYlhzPVwiXSxcImJ1aWxkQ2hhbm5lbFwiOlwiYmV0YVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCI3ODk4YTI1OS02NjRhLTQwNTItODM4Mi05YzcyNzlhZTMyNDlcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwicHVibGljS2V5XCI6XCJpTWhSSGY5MnEyM05ueUpKTnBleVZ0S2JTaUNSRkxtS1g3UFE1bHJmaWs4PVwiLFwic3R1ZGllc1wiOltdLFwidHlwZVwiOlwic2F2ZWRcIn0iLCJzaWduYXR1cmUiOiJzTWQzVlZMVkdFc1pUU2hxOHkrMkR2dUluYXZPZGRPVnVkd3FFUEFDMHJCWEREekpCRVFRTUI4TGdYYVU3YjM0aUdZSUNOWWtzSjRlUGxEOGZXTWVrUT09IiwidCI6IjNBUFhURmRHSiswMUp0ZWhiVEYvUFJuRDNZS1hzTlpYS2w5REVJMzRLYzNOaVJiME1nTGUrRE5wSkgwb3FDZ0VtZGNxbjFLakV5M1kwY3dxa0xpVEpnPT0ifQ==
  Content: {"blindedPaymentTokens":["Hlym9G/LgCuas5ANGv/+KsobYe+4o4KieleG+fdBbXs="],"buildChannel":"beta","creativeInstanceId":"7898a259-664a-4052-8382-9c7279ae3249","payload":{},"platform":"linux","publicKey":"iMhRHf92q23NnyJJNpeyVtKbSiCRFLmKX7PQ5lrfik8=","studies":[],"type":"saved"}
  Content Type: application/json
  Method: kPost
[28698:28698:0203/024945.432845:VERBOSE1:redeem_unblinded_token.cc(90)] OnCreateConfirmation
[28698:28698:0203/024945.432899:VERBOSE6:redeem_unblinded_token.cc(92)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v2/confirmation/c3585488-aad6-47c7-9dc6-dc033c31d81e/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlbnNcIjpbXCJIbHltOUcvTGdDdWFzNUFOR3YvK0tzb2JZZSs0bzRLaWVsZUcrZmRCYlhzPVwiXSxcImJ1aWxkQ2hhbm5lbFwiOlwiYmV0YVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCI3ODk4YTI1OS02NjRhLTQwNTItODM4Mi05YzcyNzlhZTMyNDlcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwicHVibGljS2V5XCI6XCJpTWhSSGY5MnEyM05ueUpKTnBleVZ0S2JTaUNSRkxtS1g3UFE1bHJmaWs4PVwiLFwic3R1ZGllc1wiOltdLFwidHlwZVwiOlwic2F2ZWRcIn0iLCJzaWduYXR1cmUiOiJzTWQzVlZMVkdFc1pUU2hxOHkrMkR2dUluYXZPZGRPVnVkd3FFUEFDMHJCWEREekpCRVFRTUI4TGdYYVU3YjM0aUdZSUNOWWtzSjRlUGxEOGZXTWVrUT09IiwidCI6IjNBUFhURmRHSiswMUp0ZWhiVEYvUFJuRDNZS1hzTlpYS2w5REVJMzRLYzNOaVJiME1nTGUrRE5wSkgwb3FDZ0VtZGNxbjFLakV5M1kwY3dxa0xpVEpnPT0ifQ==
  Response Status Code: 400
  Response: {"statusCode":400,"message":["type must be one of the following values: click, dismiss, view, landed, upvote, downvote, flag, conversion, land_30, land_60, bookmark, land_click"],"error":"Bad Request"}
[28698:28698:0203/024945.432943:VERBOSE1:redeem_unblinded_token.cc(99)] Duplicate/bad confirmation
[28698:28698:0203/024945.432970:VERBOSE1:redeem_unblinded_token.cc(118)] FetchPaymentToken
[28698:28698:0203/024945.432987:VERBOSE2:redeem_unblinded_token.cc(119)] GET /v2/confirmation/{confirmation_id}/paymentToken
[28698:28698:0203/024945.433012:VERBOSE6:redeem_unblinded_token.cc(123)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v2/confirmation/c3585488-aad6-47c7-9dc6-dc033c31d81e/paymentToken
  Method: kGet
[28698:28698:0203/024945.644534:VERBOSE1:redeem_unblinded_token.cc(134)] OnFetchPaymentToken
[28698:28698:0203/024945.644745:VERBOSE6:redeem_unblinded_token.cc(136)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v2/confirmation/c3585488-aad6-47c7-9dc6-dc033c31d81e/paymentToken
  Response Status Code: 404
  Response: {"error":"Confirmation does not exist","statusCode":404}
[28698:28698:0203/024945.644978:VERBOSE1:redeem_unblinded_token.cc(140)] Confirmation not found

Expected result:

No error

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave	1.35.85 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision	adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS	Ubuntu 18.04 LTS

cc @brave/legacy_qa @tmancey @jsecretan @rebron @amirsaber

[tmancey]

This is because the server does not recognize saved as a confirmation type. Response: {"statusCode":400,"message":["type must be one of the following values: click, dismiss, view, landed, upvote, downvote, flag, conversion, land_30, land_60, bookmark, land_click"],"error":"Bad Request"}. @jsecretan @amirsaber should the server also support this type? @btlechowski this error can be ignored if not

[saberistic]

We have bookmark, isn't that same as saved?

[tmancey]

Changing to bookmark

[tmancey]

This can ride the trains in my opinion as this was a bug and never submitted before. @amirsaber @btlechowski your thoughts?

[btlechowski]

Verification passed on

Brave	1.36.70 Chromium: 98.0.4758.66 (Official Build) nightly (64-bit)
Revision	db1b4001d5ce29f141297f260d2b778e000b85a3-refs/branch-heads/4758@{#762}
OS	Ubuntu 18.04 LTS

Verified test plan from the description.

Saved the ad in 30-day history

Verified confirmation of type bookmark is successful

[19485:19485:0127/034153.019303:VERBOSE1:confirmations.cc(69)] Confirming bookmark for ad_notification with transaction id b6a72c02-63e5-4dc4-a1f6-c7728f262682 and creative instance id 7e59d18f-5a97-4676-b06b-5af790f545e8
[19485:19485:0127/034153.020812:VERBOSE1:redeem_unblinded_token.cc(55)] Redeem unblinded token
[19485:19485:0127/034153.022788:VERBOSE1:redeem_unblinded_token.cc(74)] CreateConfirmation
[19485:19485:0127/034153.022834:VERBOSE2:redeem_unblinded_token.cc(75)] POST /v2/confirmation/{confirmation_id}/{credential}
[19485:19485:0127/034153.022879:VERBOSE6:redeem_unblinded_token.cc(79)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v2/confirmation/bacf96f4-e7ef-4af5-bee8-c3a6ffb71e20/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlbnNcIjpbXCJBQWNTMkRWb0lvVkpIcVhSMGxpTlpJcFhRb0NpN0xNSWF5WjcwOHZjamhRPVwiXSxcImJ1aWxkQ2hhbm5lbFwiOlwibmlnaHRseVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCI3ZTU5ZDE4Zi01YTk3LTQ2NzYtYjA2Yi01YWY3OTBmNTQ1ZThcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwicHVibGljS2V5XCI6XCJDQU4ycHZLZG1sT3NpYk4rOEgyZHR6WVArclhtZEN3WUNTWmRHbGlGN0hBPVwiLFwic3R1ZGllc1wiOltdLFwidHlwZVwiOlwiYm9va21hcmtcIn0iLCJzaWduYXR1cmUiOiJpTjExaFJmUkNlUjlmMTErNGFuRkRUeHZFVXp6QkVxQ0xIMkRnemozUXFzRjlESnpYSWtoZDVYTjRkVnBOeTc1T2psTm96TUpBYlgvdEdTMnNSWmFiUT09IiwidCI6InF0emJTRTlxWk5BMUR4UmNiS3l0VC9yWE9QOEQ3WkZMdC9aUU12WU5ObVUrMGxoQjlCTVBhS3ROOWRjV3lNb3ZJdmdWVS9vU3ljZUtTYTF6Q0NlSGV3PT0ifQ==
  Content: {"blindedPaymentTokens":["AAcS2DVoIoVJHqXR0liNZIpXQoCi7LMIayZ708vcjhQ="],"buildChannel":"nightly","creativeInstanceId":"7e59d18f-5a97-4676-b06b-5af790f545e8","payload":{},"platform":"linux","publicKey":"CAN2pvKdmlOsibN+8H2dtzYP+rXmdCwYCSZdGliF7HA=","studies":[],"type":"bookmark"}
  Content Type: application/json
  Method: kPost
[19485:19485:0127/034153.680558:VERBOSE1:redeem_unblinded_token.cc(90)] OnCreateConfirmation
[19485:19485:0127/034153.680601:VERBOSE6:redeem_unblinded_token.cc(92)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v2/confirmation/bacf96f4-e7ef-4af5-bee8-c3a6ffb71e20/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlbnNcIjpbXCJBQWNTMkRWb0lvVkpIcVhSMGxpTlpJcFhRb0NpN0xNSWF5WjcwOHZjamhRPVwiXSxcImJ1aWxkQ2hhbm5lbFwiOlwibmlnaHRseVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCI3ZTU5ZDE4Zi01YTk3LTQ2NzYtYjA2Yi01YWY3OTBmNTQ1ZThcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwicHVibGljS2V5XCI6XCJDQU4ycHZLZG1sT3NpYk4rOEgyZHR6WVArclhtZEN3WUNTWmRHbGlGN0hBPVwiLFwic3R1ZGllc1wiOltdLFwidHlwZVwiOlwiYm9va21hcmtcIn0iLCJzaWduYXR1cmUiOiJpTjExaFJmUkNlUjlmMTErNGFuRkRUeHZFVXp6QkVxQ0xIMkRnemozUXFzRjlESnpYSWtoZDVYTjRkVnBOeTc1T2psTm96TUpBYlgvdEdTMnNSWmFiUT09IiwidCI6InF0emJTRTlxWk5BMUR4UmNiS3l0VC9yWE9QOEQ3WkZMdC9aUU12WU5ObVUrMGxoQjlCTVBhS3ROOWRjV3lNb3ZJdmdWVS9vU3ljZUtTYTF6Q0NlSGV3PT0ifQ==
  Response Status Code: 201
  Response: {"id":"bacf96f4-e7ef-4af5-bee8-c3a6ffb71e20","payload":{},"createdAt":"2022-01-27T00:39:33.930Z","type":"bookmark","modifiedAt":"2022-01-27T00:39:33.930Z","creativeInstanceId":"7e59d18f-5a97-4676-b06b-5af790f545e8"}
[19485:19485:0127/034153.680654:VERBOSE1:redeem_unblinded_token.cc(118)] FetchPaymentToken
[19485:19485:0127/034153.680680:VERBOSE2:redeem_unblinded_token.cc(119)] GET /v2/confirmation/{confirmation_id}/paymentToken
[19485:19485:0127/034153.680698:VERBOSE6:redeem_unblinded_token.cc(123)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v2/confirmation/bacf96f4-e7ef-4af5-bee8-c3a6ffb71e20/paymentToken
  Method: kGet
[19485:19485:0127/034153.950493:VERBOSE1:redeem_unblinded_token.cc(134)] OnFetchPaymentToken
[19485:19485:0127/034153.950688:VERBOSE6:redeem_unblinded_token.cc(136)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v2/confirmation/bacf96f4-e7ef-4af5-bee8-c3a6ffb71e20/paymentToken
  Response Status Code: 202
  Response: {"error":"Payment Tokens are not ready","statusCode":202}
[19485:19485:0127/034153.951064:VERBOSE1:redeem_unblinded_token.cc(162)] Payment token is not ready
[19485:19485:0127/034153.951169:VERBOSE1:confirmations.cc(301)] Failed to redeem unblinded token for ad_notification with confirmation id bacf96f4-e7ef-4af5-bee8-c3a6ffb71e20, transaction id b6a72c02-63e5-4dc4-a1f6-c7728f262682, creative instance id 7e59d18f-5a97-4676-b06b-5af790f545e8 and bookmark
[19485:19485:0127/034153.951326:VERBOSE1:confirmations.cc(213)] Added bookmark confirmation for ad_notification with id bacf96f4-e7ef-4af5-bee8-c3a6ffb71e20, transaction idb6a72c02-63e5-4dc4-a1f6-c7728f262682 and creative instance id 7e59d18f-5a97-4676-b06b-5af790f545e8 to the confirmations queue
[19485:19485:0127/034201.956995:VERBOSE1:redeem_unblinded_token.cc(55)] Redeem unblinded token
[19485:19485:0127/034201.957387:VERBOSE1:redeem_unblinded_token.cc(118)] FetchPaymentToken
[19485:19485:0127/034201.957431:VERBOSE2:redeem_unblinded_token.cc(119)] GET /v2/confirmation/{confirmation_id}/paymentToken
[19485:19485:0127/034201.957474:VERBOSE6:redeem_unblinded_token.cc(123)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v2/confirmation/bacf96f4-e7ef-4af5-bee8-c3a6ffb71e20/paymentToken
  Method: kGet
[19485:19485:0127/034202.175336:VERBOSE1:redeem_unblinded_token.cc(134)] OnFetchPaymentToken
[19485:19485:0127/034202.175378:VERBOSE6:redeem_unblinded_token.cc(136)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v2/confirmation/bacf96f4-e7ef-4af5-bee8-c3a6ffb71e20/paymentToken
  Response Status Code: 200
  Response: {"id":"bacf96f4-e7ef-4af5-bee8-c3a6ffb71e20","createdAt":"2022-01-27T00:39:33.930Z","type":"bookmark","modifiedAt":"2022-01-27T00:39:33.930Z","creativeInstanceId":"7e59d18f-5a97-4676-b06b-5af790f545e8","paymentToken":{"publicKey":"bsc5+phOJ4Ag3NwK1qHQNFVWr2glbPMDU0T+g26u3gE=","batchProof":"Ckf2KUirpWWR0G2b5tCg9GSQW+uH284/kFfKqgea5g2Xhe/5NN/itYenVj5w5e9gfcIS8kOreZBKvqlWBxYBCw==","signedTokens":["sK8iHsnFAGdsmc1Wzg6Pgdas+CWtyvjUVP7Oh8IBv28="]}}
[19485:19485:0127/034202.177742:VERBOSE1:confirmations.cc(284)] Successfully redeemed unblinded token for ad_notification with confirmation id bacf96f4-e7ef-4af5-bee8-c3a6ffb71e20, transaction id b6a72c02-63e5-4dc4-a1f6-c7728f262682, creative instance id 7e59d18f-5a97-4676-b06b-5af790f545e8 and bookmark. You now have 3 unblinded payment tokens which will be redeemed in 0 hours, 39 minutes, 38 seconds at 4:21 AM