Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Adding Master password for saved password to improve safety. #20794

Closed
HediMuhamad opened this issue Jan 31, 2022 · 1 comment
Closed
Labels
closed/duplicate Issue has already been reported OS/Android Fixes related to Android browser functionality OS/Desktop

Comments

@HediMuhamad
Copy link

Description

[Feature] Adding Master password for saved password to improve safety.

Steps to Reproduce

  1. Visit these sites that their password saved.
  2. Click input box.

Actual result:

The dotted saved password will appear and others can use it.
NOTE: Others can't see the password if the input box doesn't have show button, but the password can be used easily every time.

Expected result:

Brave request for Master password to use saved password
NOTE: The Master password should require at first trying to use saved password in every Brave startup, not in every websites.

Reproduces how often:

Desktop Brave version:

Brave: 1.34.81 Chromium: 97.0.4692.99 (Official Build) (64-bit)
Revision: d740da257583289dbebd2eb37e8668928fac5ead-refs/branch-heads/4692@{#1461}
OS: Windows 10 Version 20H2 (Build 19042.1466)

Android Device details:

  • Install type: (ARM, x64): arm64-v8a
  • Device type: Phone: Mi 9T Pro
  • Android version: 11 RKQ1.200826.002

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? Yes

Miscellaneous Information:

Issue Briefly: The Others can access the PC owner's accounts without permission when the PC owner only allows someone else to use the PC.

@HediMuhamad HediMuhamad added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jan 31, 2022
@fmarier
Copy link
Member

fmarier commented Feb 1, 2022

See #13350.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported OS/Android Fixes related to Android browser functionality OS/Desktop
Projects
None yet
Development

No branches or pull requests

2 participants