Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State-level ad targeting setting is not shown after regional format changes #21038

Closed
aseren opened this issue Feb 11, 2022 · 2 comments · Fixed by brave/brave-core#13888
Closed

State-level ad targeting setting is not shown after regional format changes #21038

aseren opened this issue Feb 11, 2022 · 2 comments · Fixed by brave/brave-core#13888
Assignees
@tmancey
Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.42.x - Release

Comments

@aseren
Copy link

aseren commented Feb 11, 2022

Steps to reproduce:

  • Set State-level ad targeting browser setting value to Indiana (or any value except Auto-detected)
  • Change Regional format Windows setting to English (Australia). Restart the browser.
  • State-level ad targeting browser setting becomes hidden. This is expected.
  • Change Regional format Windows setting back to English (United States). Restart the browser again.

Actual result:

  • State-level ad targeting browser setting remains hidden.

Expected result:

  • State-level ad targeting browser setting becomes visible.

Reproduces how often:

Easily reproduced
@tmancey tmancey added bug and removed QA/Yes labels Feb 15, 2022
@tmancey tmancey added OS/Android Fixes related to Android browser functionality OS/iOS Fixes related to iOS browser functionality labels Feb 15, 2022
@tmancey tmancey self-assigned this Jun 21, 2022
@tmancey tmancey added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 21, 2022
@tmancey tmancey mentioned this issue Jun 21, 2022
Merged
25 tasks
@tmancey tmancey added this to the 1.42.x - Nightly milestone Jun 22, 2022
@btlechowski btlechowski mentioned this issue Jul 28, 2022
Closed
@btlechowski
Copy link

QA/Blocked by #24313

@btlechowski
Copy link

btlechowski commented Jul 29, 2022 •
edited
Loading

Verification passed on

Brave 1.42.83 Chromium: 104.0.5112.69 (Official Build) (64-bit)
Revision 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS Ubuntu 18.04 LTS

Verified test plan from the description

locale change

locale: US, geo: US-CA

image

locale: PL, geo: US-CA

image

locale: US, geo: US-CA

image

The issue is still reproducible. Logged

geo changed

locale: US, geo: US-CA

image

locale: US, geo: PL-02

image

locale: US, geo: US-CA

image

@btlechowski btlechowski mentioned this issue Jul 29, 2022
Closed
@btlechowski btlechowski removed OS/Android Fixes related to Android browser functionality OS/iOS Fixes related to iOS browser functionality labels Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.42.x - Release
Development

Successfully merging a pull request may close this issue.

Fixes state-level ad targeting setting is not shown after regional format changes brave/brave-core
3 participants
@tmancey @btlechowski @aseren