Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio icon and right click context menu for muting tab can show conflicting mute status for tab #22862

Open
LaurenWags opened this issue May 16, 2022 · 1 comment
Labels
bug Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix feature/tabs-bar OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Yes repros-on-chrome

Comments

@LaurenWags
Copy link
Member

LaurenWags commented May 16, 2022

Description

If you switch between using the right-click context menu to mute/unmute tab and clicking on the audio icon to mute, the two can get out of sync. Meaning, audio icon could look like you're not muted, but right-click context menu indicates that the tab is muted.

Found while testing #22081 but reproduces in current release which is 1.38.115 so is not specific to #22081.

Steps to Reproduce

Scenario 1:

  1. Open a tab to play audio (ex. youtube video)
  2. Have video playing and click on the audio icon to mute the tab
  3. Right click on tab in tab bar
  4. Right click context menu says "Mute Tab", but tab is muted based on step 2
  5. At this point, the context menu becomes unusable - clicking on Mute Site or Unmute Site doesn't work, you must click on the audio icon to get sound back.

Actual result:

From Step 4:

1 39 a

If you swap back and forth between using right click vs clicking on audio icon, you can also get into the below situation as well:

1 39 b

Expected result:

Audio status should be in sync between the tab mute icon and right click menu option

Reproduces how often:

easily

Brave version (brave://version info)

1.38.115, 1.38.118, 1.39.x, 1.40.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome? yes (thanks @rebron)

Miscellaneous Information:

cc @rebron @simonhong

@Brave-Matt
Copy link

+1 from Community and can also reproduce myself:
https://community.brave.com/t/bug-mute-tab-button-and-context-menu-entry-are-not-synced/419521/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix feature/tabs-bar OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Yes repros-on-chrome
Projects
Status: Needs Info
Development

No branches or pull requests

3 participants