Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content setting defaults are set incorrectly and ignored #23031

Closed
bridiver opened this issue May 24, 2022 · 6 comments · Fixed by brave/brave-core#13426
Closed

Content setting defaults are set incorrectly and ignored #23031

bridiver opened this issue May 24, 2022 · 6 comments · Fixed by brave/brave-core#13426

Comments

@bridiver
Copy link
Contributor

The content settings are registered with incorrect values and the registered values are ignored (probably leftover code from plugin id removal)

@bridiver
Copy link
Contributor Author

QA should do normal setting checks for shields

@stephendonner
Copy link

QA should do normal setting checks for shields

Note: wait until #23245 and others are in and verified before circling back to this /cc @brave/qa-team

@LaurenWags
Copy link
Member

@brave/qa-team no longer need to wait for #23245 to test this issue as #23245 has been closed as a duplicate.

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 21, 2022
@stephendonner
Copy link

stephendonner commented Jun 21, 2022

Verified PASSED using

Brave 1.41.74 Chromium: 103.0.5060.53 (Official Build) beta (x86_64)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS macOS Version 12.5 (Build 21G5046c)

Confirmed defaults matched between brave://settings/shields and the Shields icon, and worked.

Steps:

  1. installed 1.41.74
  2. launched Brave
  3. opened brave://settings/shields
  4. loaded cnn.com and clicked on the Shields icon
  5. compared content-blocking defaults
brave://settings/shields Shields icon
Trackers & ads blocking Standard Block trackers & ads
Upgrade connections to HTTPS ON Upgrade connections to HTTPS ON
Block scripts OFF Block scripts OFF
Block fingerprinting Standard Block fingerprinting
Block cookies Only cross-site Block cross-site cookies
brave://settings/shields Shields icon
Screen Shot 2022-06-21 at 1 51 18 PM Screen Shot 2022-06-21 at 1 51 00 PM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 21, 2022
@stephendonner
Copy link

stephendonner commented Jun 23, 2022

Verified PASSED using

Brave 1.41.77 Chromium: 103.0.5060.53 (Official Build) beta (64-bit)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS Linux

Confirmed defaults matched between brave://settings/shields and the Shields icon, and worked.

Steps:

  1. installed 1.41.77
  2. launched Brave
  3. opened brave://settings/shields
  4. loaded cnn.com and clicked on the Shields icon
  5. compared content-blocking defaults
brave://settings/shields Shields icon
Trackers & ads blocking Standard Block trackers & ads
Upgrade connections to HTTPS ON Upgrade connections to HTTPS ON
Block scripts OFF Block scripts OFF
Block fingerprinting Standard Block fingerprinting
Block cookies Only cross-site Block cross-site cookies
brave://settings/shields Shields panel
Screen Shot 2022-06-23 at 2 33 02 PM Screen Shot 2022-06-23 at 2 33 30 PM

@MadhaviSeelam
Copy link

Verification Passed using

Brave | 1.41.86 Chromium: 103.0.5060.66 (Official Build) beta (64-bit)
-- | --
Revision | 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS | Windows 11 Version 21H2 (Build 22000.739)

Confirmed defaults matched between brave://settings/shields and the Shields icon.

Steps:

  1. installed 1.41.86
  2. launched Brave
  3. loaded nytimes.com and clicked on the Shields icon
  4. click Advanced controls>>Global defaults
  5. compared content-blocking defaults on brave://settings/shields page
brave://settings/shields Shields icon
Trackers & ads blocking Standard Block trackers & ads
Upgrade connections to HTTPS ON Upgrade connections to HTTPS ON
Block scripts OFF Block scripts OFF
Block fingerprinting Standard Block fingerprinting
Block cookies Only cross-site Block cross-site cookies
shields panel settings page
image image

Performed regression on global defaults page:
Steps:

  1. installed 1.41.86
  2. launched Brave
  3. load nytimes.com
  4. click Shields icon to open shields panel
  5. click Advanced controls>Global defaults
  6. switch to Aggressive in Trackers & ads blocking`
  7. switch to All in Block cookies
  8. return to nytimes.com and verified correct values shown in the shields panel
  9. go to brave://settings/cookies and verified Block all cookies was selected
  10. reset global defaults to original settings from clear browsing data>>Advanced>>Site and Shields settings
  11. also click Reset settings on brave://settings page to reset values in the global defaults page
  12. default values are shown in the brave://settings/shields page
Step 6 & 7 Step 8 Step 9 Step 10 Step 12
image image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment