-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content setting defaults are set incorrectly and ignored #23031
Labels
Milestone
Comments
25 tasks
QA should do normal setting checks for shields |
Note: wait until #23245 and others are in and verified before circling back to this /cc @brave/qa-team |
stephendonner
added
the
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
label
Jun 21, 2022
Verified
|
Brave | 1.41.74 Chromium: 103.0.5060.53 (Official Build) beta (x86_64) |
---|---|
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853} |
OS | macOS Version 12.5 (Build 21G5046c) |
Confirmed defaults matched between brave://settings/shields and the Shields icon, and worked.
Steps:
- installed
1.41.74
- launched Brave
- opened
brave://settings/shields
- loaded
cnn.com
and clicked on the Shields icon - compared content-blocking defaults
brave://settings/shields | Shields icon |
---|---|
Trackers & ads blocking Standard |
Block trackers & ads |
Upgrade connections to HTTPS ON |
Upgrade connections to HTTPS ON |
Block scripts OFF |
Block scripts OFF |
Block fingerprinting Standard |
Block fingerprinting |
Block cookies Only cross-site |
Block cross-site cookies |
brave://settings/shields |
Shields icon |
---|---|
stephendonner
added
QA Pass-macOS
and removed
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
labels
Jun 21, 2022
Verified
|
Brave | 1.41.77 Chromium: 103.0.5060.53 (Official Build) beta (64-bit) |
---|---|
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853} |
OS | Linux |
Confirmed defaults matched between brave://settings/shields and the Shields icon, and worked.
Steps:
- installed
1.41.77
- launched Brave
- opened
brave://settings/shields
- loaded
cnn.com
and clicked on the Shields icon - compared content-blocking defaults
brave://settings/shields | Shields icon |
---|---|
Trackers & ads blocking Standard |
Block trackers & ads |
Upgrade connections to HTTPS ON |
Upgrade connections to HTTPS ON |
Block scripts OFF |
Block scripts OFF |
Block fingerprinting Standard |
Block fingerprinting |
Block cookies Only cross-site |
Block cross-site cookies |
brave://settings/shields |
Shields panel |
---|---|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
The content settings are registered with incorrect values and the registered values are ignored (probably leftover code from plugin id removal)
The text was updated successfully, but these errors were encountered: