Shields cookies/fingerprinting settings not saving in brave://settings/shields

[emerick]

Description

Cookies/fingerprinting settings not saving in brave://settings/shields

Steps to Reproduce

1. Visit brave://settings/shields
2. Change "Block cookies" or "Block fingerprinting" setting
3. Close tab
4. Reopen brave://settings/shields

Actual result:

Old cookie/fingerprinting setting shows.

Expected result:

New cookie/fingerprinting setting shows.

Reproduces how often:

Easily.

Brave version (brave://version info)

Latest master (I'm on Windows 11).

Version/Channel Information:

Started in version 1.41.32

• Can you reproduce this issue with the current release? no
• Can you reproduce this issue with the beta channel? no
• Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[emerick]

JavaScript console shows:

polymer_bundled.min.js:1 method `controlEqual` not defined

[rebron]

cc: @nullhook

[bridiver]

Just to be clear this is a display issue in the UI. The settings are correct, they just don't display correctly.

[stephendonner]

Verified PASSED using

Brave	1.41.65 Chromium: 103.0.5060.42 (Official Build) nightly (x86_64)
Revision	de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS	macOS Version 11.6.7 (Build 20G630)

Steps:

1. installed 1.41.65
2. launched Brave
3. opened a couple tabs
4. opened brave://settings/shields
5. confirmed pref defaults
6. changed Block fingerprinting to Strict, may break sites
7. changed Block cookies to All
8. closed the Settings tab
9. opened brave://settings/shields in a new tab
10. noted values of Block fingerprinting and Block cookies
11. opened cnn.com in a new tab
12. expanded the Shields UI to see the defaults coming through

Confirmed default Shields values were those I customized from steps 6 & 7

step 5	step 6 & 7	step 10	step 12

[MadhaviSeelam]

Verification PASSED using

Brave | 1.41.72 Chromium: 103.0.5060.42 (Official Build) beta (64-bit)
-- | --
Revision | de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS | Windows 11 Version 21H2 (Build 22000.739)

Steps:

1. installed 1.41.72
2. launched Brave
3. opened a couple tabs
4. opened brave://settings/shields
5. confirmed pref defaults
6. changed Block fingerprinting to Strict, may break sites
7. changed Block cookies to All
8. closed the Settings tab
9. opened brave://settings/shields in a new tab
10. New values are saved for Block fingerprinting and Block cookies
11. opened cnn.com in a new tab
12. expanded the Shields UI

Confirmed default Shields values were those I customized from steps 6 & 7

Step 5	Step6&7	Step9&10	Step 12

[stephendonner]

Verification PASSED using

Brave	1.41.84 Chromium: 103.0.5060.66 (Official Build) beta (64-bit)
Revision	20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS	Linux

Steps:

1. installed 1.41.84
2. launched Brave
3. opened a couple tabs
4. opened brave://settings/shields
5. confirmed pref defaults
6. changed Block fingerprinting to Strict, may break sites
7. changed Block cookies to All
8. closed the Settings tab
9. opened brave://settings/shields in a new tab
10. noted values of Block fingerprinting and Block cookies
11. opened cnn.com in a new tab
12. expanded the Shields UI to see the defaults coming through

Confirmed default Shields values were those I customized from steps 6 & 7

step 5	step 6 & 7	step 10	step 12