Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trezor transaction fails #23448

Closed
srirambv opened this issue Jun 14, 2022 · 7 comments
Closed

Trezor transaction fails #23448

srirambv opened this issue Jun 14, 2022 · 7 comments
Assignees
Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/web3/wallet/hardwaresupport feature/web3/wallet Integrating Ethereum+ wallet support needs-investigation A bug not 100% confirmed/fixed OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes regression release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Trezor transaction fails

Steps to Reproduce

  1. Connect Trezor and import accounts
  2. Initiate a send ETH transaction from Trezor to another account
  3. Once session authentication is done, automatically rejects the transaction

Actual result:

Trezor.Failed.Transaction.mp4

Expected result:

Should show the transaction approval on the device so user can approve/reject it via the device

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.41.61 Chromium: 103.0.5060.42 (Official Build) nightly (64-bit)
Revision de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS Windows 11 Version 21H2 (Build 22000.708)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/crypto-wallets

@onyb
Copy link
Member

onyb commented Jun 15, 2022

Could not reproduce on Trezor Model T (firmware 2.5.1). Tested with Nightly version on Ethereum mainnet network.

@srirambv Can you please reproduce the issue again using brave://wallet-panel.top-chrome and looking at the console logs?

@srirambv
Copy link
Contributor Author

@onyb am just seeing session not found

23448-wallet-top.chrome.mp4

@srirambv
Copy link
Contributor Author

Update: Rechecked the issue on Mainnet and the transactions went through without issues.

@srirambv srirambv added needs-investigation A bug not 100% confirmed/fixed and removed release/blocking labels Jun 15, 2022
@jamesmudgett jamesmudgett added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jun 24, 2022
@bbondy
Copy link
Member

bbondy commented Jul 4, 2022

Should this be closed @srirambv ?

@srirambv
Copy link
Contributor Author

srirambv commented Jul 5, 2022

Just rechecked the issue. Seems to work on Mainnet but its still an issue on Testnet. I am ok to close the issue but might be good to get it fixed for testnet at least

@nvonpentz
Copy link
Member

@srirambv Confirmed the issue is just on mainnet. It seems testnets are off by default for Trezor. To enable them, you must go to https://suite.trezor.io/web/settings/device > Safety Checks > Edit, then select 'Prompt'. After making that change, I was able to send transactions on Sepolia.

@srirambv
Copy link
Contributor Author

srirambv commented Nov 9, 2023

Able to send on testnet after updating the Safety check permission. Closing the issue as invalid. Thanks for the steps @nvonpentz

@srirambv srirambv closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
@srirambv srirambv added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/web3/wallet/hardwaresupport feature/web3/wallet Integrating Ethereum+ wallet support needs-investigation A bug not 100% confirmed/fixed OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes regression release-notes/exclude
Projects
Archived in project
Development

No branches or pull requests

8 participants