Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAapps: UI fixes #23556

Closed
3 tasks
Pavneet-Sing opened this issue Jun 20, 2022 · 1 comment · Fixed by brave/brave-core#13987
Closed
3 tasks

DAapps: UI fixes #23556

Pavneet-Sing opened this issue Jun 20, 2022 · 1 comment · Fixed by brave/brave-core#13987
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.42.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Jun 20, 2022 •
edited
Loading

Sign Request:

  • Remove tab white underline in dark mode on sign fragment

Screenshot from 2022-06-20 22-05-53

  • Show a gradient separator (pink-line under message on ) instead of a plain pink one
  • The negative button (Cancel) should not have a primary (blue) background and have click effect
@Pavneet-Sing Pavneet-Sing mentioned this issue Jun 20, 2022
Open
3 tasks
@Pavneet-Sing Pavneet-Sing added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality feature/web3/wallet/dapps labels Jun 20, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Jun 20, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Jun 20, 2022
Merged
25 tasks
@Pavneet-Sing Pavneet-Sing changed the title Remove tab white underline in dark mode on sign fragment DAapps: UI fixes Jun 20, 2022
@Pavneet-Sing Pavneet-Sing added feature/web3/wallet Integrating Ethereum+ wallet support release-notes/include and removed release-notes/exclude labels Jun 24, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Jun 28, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.42.x - Nightly milestone Jun 29, 2022
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.42.67 x64 build

Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
23556-ARM.mp4
23556-Tab.mp4

@srirambv srirambv mentioned this issue Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.42.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): UI dapps issues brave/brave-core
3 participants
@Pavneet-Sing @srirambv @brave-builds