-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Webtorrent and downloads window #23962
Comments
I don't think just a split window is enough of a solution. In my opinion, if you are going to have built-in torrent support it really needs to be fully integrated into the downloads page. The current extension-like implementation feels really half-baked.
You need to keep the torrent tab open. Closing it interrupts the download of all individual files you selected to save, with no way to resume, losing all progress. That's inconsistent with how downloads usually work. There are no warnings about that either, you learn it "the hard way". |
I agree that we need a properly integrated downloads section, imho all items mentioned by @anonghuser are very important and most deserve their own issue. My proposal is meant to be just an inital seed into making this integration a reality. The split window is not enough but it would already help a lot, with very small coding required for the implementation. This kind of big implementations usually takes a year or two (take the new tab implementaton #353 for eg). That why I think this is a good temporary change that can even help bringing more attention to the integration details missing. Also seems woth creating a full integration issue, tracking each feature and managing their progress. |
Since this issue already has a little compilation of webtorrent issues, I thought I should drop this here, I can open a new issue if this starts to get too broad. The "save all files" button does not account for memory limit and, for large files, will drop the entire page and show a memory limit error message, forcing the user to re-download all the torrents content again. |
If the screens is large enough there could be an iframe to the downloads window next to the webtorrent files window, like splitting the screen in the middle. And on android/smaller screens the downloads window could always come after the webtorrent.
The reason is cuz it's really odd to have two tabs to follow torrent downloads. Even a single download requires the user to have two tabs opened to check on the download details and if you go for multiple downloads it becomes a tab nightmare.
The text was updated successfully, but these errors were encountered: