Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase test playlist webui components/playlist/resources and others #24027

Closed
Tracked by #23621
sangwoo108 opened this issue Jul 13, 2022 · 3 comments · Fixed by brave/brave-core#14198
Closed
Tracked by #23621

Rebase test playlist webui components/playlist/resources and others #24027

sangwoo108 opened this issue Jul 13, 2022 · 3 comments · Fixed by brave/brave-core#14198
Assignees
@sangwoo108
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.43.x - Release

Comments

@sangwoo108
Copy link

sangwoo108 commented Jul 13, 2022 •
edited
Loading

sub task of #23621
@sangwoo108 sangwoo108 mentioned this issue Jul 13, 2022
Closed
14 tasks
@sangwoo108 sangwoo108 self-assigned this Jul 13, 2022
@sangwoo108 sangwoo108 added priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude labels Jul 13, 2022
@simonhong
Copy link
Member

simonhong commented Jul 15, 2022 •
edited
Loading

It would be nice to have test webui like brave://playlist.
I think putting it as a sidebar item would be great.
cc @rebron @bsclifton @petemill

@sangwoo108 sangwoo108 mentioned this issue Jul 15, 2022
Merged
25 tasks
@sangwoo108
Copy link
Author

sangwoo108 commented Jul 15, 2022 •
edited
Loading

It would be nice to have test webui like brave://playlist.
think putting it as a sidebar item would be great.

Yeah. That's cool. I'll try attaching a button on the sidebar on the current PR.

@simonhong
Copy link
Member

It would be nice to have test webui like brave://playlist.
think putting it as a sidebar item would be great.

Yeah. That's cool. I'll try attaching a button on the sidebar on the current PR.

Let's do it after @petemill completes sidepanel integration to sidebar (brave/brave-core#13769).
It has many sidebar impls changes. If you do that now, it'll make many conflicts.

@brave-builds brave-builds added this to the 1.43.x - Nightly milestone Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangwoo108 sangwoo108

Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
1.43.x - Release
Development

Successfully merging a pull request may close this issue.

Wire playlist webui brave/brave-core
3 participants
@sangwoo108 @simonhong @brave-builds