Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bind wallet transactions to a specific network rather than using current selected network afterwards #24384

Closed
Pavneet-Sing opened this issue Aug 2, 2022 · 1 comment · Fixed by brave/brave-core#18477
Closed

Bind wallet transactions to a specific network rather than using current selected network afterwards #24384

Pavneet-Sing opened this issue Aug 2, 2022 · 1 comment · Fixed by brave/brave-core#18477
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/exclude
Milestone
1.56.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Aug 2, 2022 •
edited
Loading

Description

Currently we are always using selected networks when sending out transactions, and lack of support for pending transactions with different networks.
We need to bind transactions to a network it is supposed to be sending out, and expose them via TransactionInfo.

Related issues:

Miscellaneous Information:

Front-end issue
@Pavneet-Sing Pavneet-Sing added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality feature/web3/wallet/core labels Aug 2, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Aug 3, 2022
Closed
@yrliou yrliou changed the title Implement a way to get the corresponding network name from the transaction info Bind wallet transactions to a specific network rather than using current selected network afterwards Aug 3, 2022
@yrliou yrliou self-assigned this Aug 3, 2022
@yrliou yrliou added priority/P3 The next thing for us to work on. It'll ride the trains. and removed OS/iOS Fixes related to iOS browser functionality labels Aug 4, 2022
@yrliou yrliou removed their assignment Apr 11, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue May 15, 2023
Merged
25 tasks
@Pavneet-Sing Pavneet-Sing self-assigned this May 15, 2023
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 16, 2023
@srirambv
Copy link
Contributor

Verified as part of #30277 (comment)

@kjozwiak kjozwiak mentioned this issue Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

Fix transaction balance and network brave/brave-core
5 participants
@kjozwiak @yrliou @Pavneet-Sing @srirambv @brave-builds