Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Brave is up to date" checkmark is Chrome blue instead of a Brave specific color #24465

Open
LaurenWags opened this issue Aug 5, 2022 · 3 comments
Assignees
Labels
design A design change, especially one which needs input from the design team OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude

Comments

@LaurenWags
Copy link
Member

Description

The checkmark on brave://settings/help indicating that you have the latest version should be more Brave and less Chrome (the blue). The blue checkmark looks out of place on this page and should be a different Brave color.

Steps to Reproduce

  1. Navigate to brave://settings/help
  2. If you have the latest version, you'll see a blue checkmark icon
  3. If you don't have the latest version, update and then go to this page. See step 2.

Actual result:

blue check mark

Expected result:

Blue checkmark icon to be more Brave-ified

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.44.23 Chromium: 104.0.5112.81 (Official Build) nightly (x86_64)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS macOS Version 12.5 (Build 21G72)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes but it's not new with C104
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron

@LaurenWags LaurenWags added design A design change, especially one which needs input from the design team QA/Yes OS/Desktop labels Aug 5, 2022
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". release-notes/exclude polish Nice to have — usually related to front-end/visual tasks labels Aug 5, 2022
@rebron
Copy link
Collaborator

rebron commented Aug 9, 2022

@aguscruiz One more related to remove the Chrome blue.

@aguscruiz
Copy link

@BrajBliss
Copy link

BrajBliss commented Aug 16, 2022

Hey, can I take this up? First time here, let me know the folder/files if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude
Projects
Status: P4 Backlog
Development

No branches or pull requests

4 participants