Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields breaking text/fonts on some websites (followup) #24468

Closed
pilgrim-brave opened this issue Aug 5, 2022 · 4 comments · Fixed by brave/brave-core#14489
Closed

Shields breaking text/fonts on some websites (followup) #24468

pilgrim-brave opened this issue Aug 5, 2022 · 4 comments · Fixed by brave/brave-core#14489

Comments

@pilgrim-brave
Copy link

#23093 (comment)

"""
I experienced this issue and arrived here after some basic troubleshooting and finding that turning down shields allowed our font stack to work as expected. At the time, I was running macOS 12.4 and a slightly outdated version of Brave.

The font stack is Inter, -apple-system, BlinkMacSystemFont, avenir next, avenir, helvetica neue, helvetica, Ubuntu, roboto, noto, segoe ui, arial, sans-serif, and the font that I was seeing was avenir. So the browser was skipping Inter (despite Inter being installed correctly and having worked as expected with this font stack previously) and also skipping the two apple system font declarations. Again, turning down shields allowed the stack to perform as expected.

Next, I updated Brave to 1.42.86, which was after the fix announced above, and that did not improve the issue. Only after updating macOS to 12.5 was the issue resolved.

Hope this helps!
"""

@LaurenWags
Copy link
Member

from @pes10k:

QA test: https://dev-pages.brave.software/fingerprinting/fonts.html
(the “Pseudo Fonts” section)

@LaurenWags
Copy link
Member

Requires 1.42.90 or higher to test

@stephendonner
Copy link

stephendonner commented Aug 10, 2022

Verified PASSED using

Brave 1.42.91 Chromium: 104.0.5112.81 (Official Build) (x86_64)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS macOS Version 13.0 (Build 22A5321d)

Steps:

  1. installed 1.42.91
  2. installed the Fredoka One font
  3. launched Brave
  4. loaded https://dev-pages.brave.software/fingerprinting/fonts.html and https://dev-pages.bravesoftware.com/fingerprinting/fonts.html
  5. clicked on Start tests
  6. checked the Pseudo Fonts section's output

Confirmed the Control and Test font were rendered the same and with the same width: 343 pixels

dev-pages.brave.software dev-pages.bravesoftware.com/
Screenshot 2022-08-10 at 11 44 48 AM Screenshot 2022-08-10 at 11 44 57 AM

Fredoka One

Screenshot 2022-08-10 at 12 07 02 PM

@MadhaviSeelam
Copy link

MadhaviSeelam commented Aug 10, 2022

Added OS/macOS label to this issue. Per discussion with @pes10k, this is only applicable to macOS, see https://bravesoftware.slack.com/archives/CD495CWLR/p1660159116959389?thread_ts=1660158731.020959&cid=CD495CWLR for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment