Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching between top tile types w/pagination gets stuck #24688

Closed
stephendonner opened this issue Aug 16, 2022 · 2 comments · Fixed by brave/brave-core#14784
Closed

Switching between top tile types w/pagination gets stuck #24688

stephendonner opened this issue Aug 16, 2022 · 2 comments · Fixed by brave/brave-core#14784

Comments

@stephendonner
Copy link

Description

Switching between top tile types w/pagination gets stuck

Steps to Reproduce

  1. install 1.44.44
  2. launch Brave
  3. load and bookmark 12+ sites
  4. open a new-tab page
  5. toggle to Show favorites
  6. click to switch to the 2nd page
  7. toggle to Show frequently visited
  8. toggle back to Show favorites
  9. try to click to change pages

Actual result:

Pagination is stuck, and you're unable to return to the 1st page

favorites-broken

Expected result:

Pagination should still work, after switching between Favorites/Frequently-Visited Sites

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.44.44 Chromium: 104.0.5112.81 (Official Build) nightly (x86_64)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS macOS Version 11.6.8 (Build 20G730)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @fallaciousreasoning @rebron

@fallaciousreasoning
Copy link

fallaciousreasoning commented Aug 16, 2022

Interesting, I can't actually reproduce this in 1.44.32, 1.44.37, 1.44.43 (Latest Nightly) but I could in 1.43.67 & 1.43.71 (Beta). I'm wondering if this is already fixed?

Couldn't repro at ToT either 1.44.48 either.

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.45.48 Chromium: 105.0.5195.127 (Official Build) nightly (x86_64)
Revision 912488396852bf658ab32465980c0b93a3c27a83-refs/branch-heads/5195@{#1109}
OS macOS Version 11.7 (Build 20G817)

Followed my original steps to reproduce, and confirmed it's fixed

example example example example example example example
Screen Shot 2022-09-14 at 11 30 07 PM Screen Shot 2022-09-14 at 11 30 25 PM Screen Shot 2022-09-14 at 11 31 13 PM Screen Shot 2022-09-14 at 11 31 25 PM Screen Shot 2022-09-14 at 11 31 30 PM Screen Shot 2022-09-14 at 11 34 45 PM Screen Shot 2022-09-14 at 11 31 36 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment