Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save all files button should be disabled until Start #24958

Closed
stephendonner opened this issue Aug 24, 2022 · 6 comments · Fixed by brave/brave-core#16002
Closed

Save all files button should be disabled until Start #24958

stephendonner opened this issue Aug 24, 2022 · 6 comments · Fixed by brave/brave-core#16002

Comments

@stephendonner
Copy link

Description

Save all files button should be disabled until Start

Steps to Reproduce

  1. install 1.44.60
  2. launch Brave
  3. load https://webtorrent.io/free-torrents
  4. click on the magnet link for any of the files
  5. in the resulting WebTorrent view, look at the Save all files button

Actual result:

Save all files button is enabled, but doesn't do anything (until after you start the torrent)

Screenshot 2022-08-24 at 3 02 08 PM

Expected result:

Save all files button should be disabled until after you've started the torrent

Reproduces how often:

Brave version (brave://version info)

Brave 1.44.60 Chromium: 105.0.5195.37 (Official Build) nightly (x86_64)
Revision 5f67e9f258cc28ab970e57572290edf1863ee3c5-refs/branch-heads/5195@{#621}
OS macOS Version 13.0 (Build 22A5321d)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @fallaciousreasoning

@fallaciousreasoning
Copy link

I think it should actually be disabled until the torrent has finished downloading - it zips the files up and does nothing until then anyway.

@ben-marrett
Copy link

I'm keen to work on this issue.

@fallaciousreasoning
Copy link

Awesome, go for it! A good starting place is probably in brave/components/brave_webtorrent/extension/components/torrentFileList.tsx. When you have something, add me as a reviewer on the PR!

@panoplied
Copy link

@fallaciousreasoning unable to add you as a reviewer, but check the PR #brave/brave-core#14977

@fallaciousreasoning
Copy link

Wohoo! Thanks for the contribution @panoplied. I'm just kicking off CI, when it finishes we should be good to merge

@stephendonner
Copy link
Author

stephendonner commented Dec 3, 2022

Verified PASSED using

Brave 1.47.110 Chromium: 108.0.5359.71 (Official Build) beta (x86_64)
Revision 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS macOS Version 13.1 (Build 22C5059b)

Torrent file:

default in-progress complete save all files
Screenshot 2022-12-02 at 10 36 25 PM Screenshot 2022-12-02 at 10 36 34 PM Screenshot 2022-12-02 at 10 36 44 PM Screenshot 2022-12-02 at 10 37 11 PM

Magnet link:

default in-progress complete save all files
Screenshot 2022-12-02 at 10 54 58 PM Screenshot 2022-12-02 at 10 55 05 PM Screenshot 2022-12-02 at 10 55 19 PM Screenshot 2022-12-02 at 10 56 02 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment